Added product fee to the quote #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luisfc68
requested changes
Dec 12, 2023
docker-compose/local/.env.regtest
Outdated
| AWS_ACCESS_KEY_ID= | ||
| AWS_SECRET_ACCESS_KEY= | ||
| AWS_REGION= | ||
| [email protected] |
There was a problem hiding this comment.
we dont use mailgun anymore
docker-compose/local/.env.regtest
Outdated
| [email protected] | ||
| MAILGUN_DOMAIN=b30c8b203ade9013f16fbd24232f7580-102c75d8-2e73f63d | ||
|
|
||
| AWS_ACCESS_KEY_ID=AKIARRR3WWCRU722UAHK |
There was a problem hiding this comment.
please dont push this to the repo !!
| @@ -74,6 +74,7 @@ const GetCollateralError = "Unable to get collateral" | |||
| const ErrorAddingProvider = "Error Adding New provider: %v" | |||
| const ErrorRetrivingProviderAddress = "Error Retrieving Provider Address from MongoDB" | |||
| const ErrorNotLiquidity = "Not enough liquidity" | |||
| const ErrorRetrievingDaoFeePercentage = "Error retrieving dao fee percentage" | |||
There was a problem hiding this comment.
We need to stop doing this pattern of error msg and switch to sentinel errors (not to you or this PR, just adding to my tech debt list)
http/server.go
Outdated
| @@ -1260,6 +1283,7 @@ func getPegOutProviderByAddress(liquidityProviders []pegout.LiquidityProvider, a | |||
| } | |||
|
|
|||
| func (s *Server) storeQuote(q *pegin.Quote) (string, error) { | |||
| log.Debug(q.ProductFeeAmount) | |||
There was a problem hiding this comment.
pls delete this or add more context to the message
connectors/rsk.go
Outdated
| @@ -980,6 +982,7 @@ func (rsk *RSK) ParsePegOutQuote(q *pegout.Quote) (bindings.QuotesPegOutQuote, e | |||
| pq.TransferTime = q.TransferTime | |||
| pq.ExpireDate = q.ExpireDate | |||
| pq.ExpireBlock = q.ExpireBlock | |||
| pq.ProductFeeAmount = types.NewWei(int64(q.ProductFeeAmount)).AsBigInt() | |||
There was a problem hiding this comment.
why do you parse using wei here and above you parse using big int directly?
|
Luisfc68
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.