Skip to content

Commit

Permalink
fix: feedback | remove unused value & improve indexing
Browse files Browse the repository at this point in the history
  • Loading branch information
Dominikkq committed Dec 5, 2024
1 parent 0c5e896 commit 788d1da
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions internal/adapters/entrypoints/rest/assets/management.html
Original file line number Diff line number Diff line change
Expand Up @@ -271,10 +271,8 @@ <h5 class="card-title">Current Configuration</h5>
const entriesContainer = document.createElement('div');
entriesContainer.classList.add('entries-container');

let index = 0;
Object.entries(confirmations).forEach(([amountWei, confirmation]) => {
Object.entries(confirmations).forEach(([amountWei, confirmation], index) => {
createConfirmationEntry(entriesContainer, configKey, index, amountWei, confirmation);
index++;
});

container.appendChild(entriesContainer);
Expand Down Expand Up @@ -453,8 +451,6 @@ <h5 class="card-title">Current Configuration</h5>
errors.push(`Invalid type for ${key}: expected object, got ${actualType}`);
} else {
Object.entries(value).forEach(([subKey, subValue]) => {
const subExpectedValue = expectedValue ? expectedValue[subKey] : undefined;
const subExpectedType = 'number';
const subActualType = inferType(subValue);
if (subActualType !== 'number') errors.push(`Invalid type for ${key} confirmation value of amount ${subKey}: expected number, got ${subActualType}`);
});
Expand Down

0 comments on commit 788d1da

Please sign in to comment.