Add support for zsh shell completions #3887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
commented
Nov 30, 2024
| $rr --list-commands | cut -s -d ' ' -f 3 | ||
| } | ||
| _rr_traces() { | ||
| $rr ls | grep -v '^cpu_lock$' |
There was a problem hiding this comment.
this grep -v isn't strictly necessary now that rr doesn't show cpu_lock in rr ls. but in older versions, cpu_lock was the only file shown that wouldn't be a valid trace. so it would be nice to keep this so that the script is compatible with older versions too.
There was a problem hiding this comment.
I don't see the value in having the script be compatible with older versions but I guess this is harmless.
jyn514
force-pushed
the
zsh-completion
branch
2 times, most recently
from
9a76aae to
3474507
Compare
rocallahan
requested changes
Nov 30, 2024
| $rr --list-commands | cut -s -d ' ' -f 3 | ||
| } | ||
| _rr_traces() { | ||
| $rr ls | grep -v '^cpu_lock$' |
There was a problem hiding this comment.
I don't see the value in having the script be compatible with older versions but I guess this is harmless.
jyn514
force-pushed
the
zsh-completion
branch
from
3474507 to
293d87d
Compare
This also fixes `rr ls` not to list pre-installed files as traces.
jyn514
force-pushed
the
zsh-completion
branch
from
293d87d to
5aa1bcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes
rr lsnot to list pre-installed files as traces.cc #3681