-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patch section for USB/IP #15
base: master
Are you sure you want to change the base?
Conversation
For some kernel versions USB/IP may require a patch in order to compile. These are fixed in current kernel versions, but some may not have the patches in their version. Added information for these patches: stringop-trunctation in usbip_device_driver.c, and address-of-packed-member in usbip_network.c
@@ -131,6 +131,27 @@ Build USBIP tools: | |||
/usr/src/4.19.43-microsoft-standard/tools/usb/usbip$ sudo make install -j 12 | |||
``` | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for the commit. Q: Is this compiler message occurring because of an upgrade to GCC v8? Any ideas on why it did not occur before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for replying! First of all, my kernel version is 4.19.104
on Ubuntu 20 with gcc 9.3.0
. The USB/IP Makefiles seem to be settings the -Werror
flag, so all of these small warnings will make the build fail. These errors are new features in gcc 9 so that could be why they haven't shown up before. I updated the README to reflect that as well.
The need for the patches has been updated to reflect why they are now showing up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely helpful and necessary and merging it as is would be an improvement. Even better would be to include the patch files in this repo and include wget and patch commands for applying the patches. While that may seem a bit excessive given we're compiling a kernel, the rest of the instructions are so straightforward and detailed that very little programming knowledge is needed to follow them.
Cleaned up code Updated README to recommend using the apply_patches script Updated README with example usages Typo
Just added a script to apply the patches in question. It can also handle applying a generic patch set in case new patches are needed in the future. I updated the README to reflect this. |
When using your branch:
|
For some kernel versions USB/IP may require a patch in order to compile. These are fixed in current kernel versions, but some may not have the patches in their version.
Added information for these patches: stringop-trunctation in usbip_device_driver.c, and address-of-packed-member in usbip_network.c