Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

27 startup script #32

Merged
merged 10 commits into from
Jun 3, 2024
Merged

27 startup script #32

merged 10 commits into from
Jun 3, 2024

Conversation

iandareid
Copy link
Collaborator

This is a simple start up script that allows you to launch ROSplane in simulation or for a flight test. It has some simplistic options but it is a good start. In my experience it dramatically speeds up testing since you do not have to setup the environment yourself.

@iandareid iandareid added the enhancement New feature or request label May 22, 2024
@iandareid iandareid self-assigned this May 22, 2024
@iandareid iandareid linked an issue May 22, 2024 that may be closed by this pull request
@iandareid
Copy link
Collaborator Author

It requires tmux on a base station computer, but we do not have that listed as a dependency anywhere, should we add it? Or just let people discover they need it if they choose to use this file?

@iandareid
Copy link
Collaborator Author

Also is it okay to leave this in rosplane? Should it be moved to the rosflight_gcs?

rosplane/scripts/rosplane_gcs_launch.sh Outdated Show resolved Hide resolved
rosplane/scripts/rosplane_gcs_launch.sh Outdated Show resolved Hide resolved
rosplane/scripts/rosplane_gcs_launch.sh Outdated Show resolved Hide resolved
rosplane/scripts/rosplane_gcs_launch.sh Outdated Show resolved Hide resolved
rosplane/scripts/rosplane_gcs_launch.sh Outdated Show resolved Hide resolved
if $docker; then
tmux send-keys -t rosplane_sim_session:0.0 "docker compose up -d" C-m
sleep 2
tmux send-keys -t rosplane_sim_session:0.0 "docker compose exec $container bash" C-m # TODO check these commands.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

rosplane/scripts/rosplane_gcs_launch.sh Show resolved Hide resolved
rosplane/scripts/rosplane_gcs_launch.sh Show resolved Hide resolved
@bsutherland333
Copy link
Collaborator

Because this is dependent on rosplane we should probably leave it in the rosplane repo. I'm not sure where is best though. Maybe we'll end up making a rosplane_gcs package at some point?

@iandareid
Copy link
Collaborator Author

That would make the most sense to me!

Consists of fixing typos and removing comments. It also better documents
the script in the code.
@iandareid iandareid requested a review from bsutherland333 June 3, 2024 16:06
@iandareid iandareid merged commit c1fd1a4 into main Jun 3, 2024
2 checks passed
@iandareid iandareid deleted the 27-startup-script branch June 3, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Make startup script to speed up testing
3 participants