Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port to 1.20.6 #4

Merged
merged 2 commits into from
May 29, 2024
Merged

port to 1.20.6 #4

merged 2 commits into from
May 29, 2024

Conversation

orifu
Copy link
Member

@orifu orifu commented May 29, 2024

port to 1.20.6. i also added fapi as a runtime dep which stops modmenu screaming

@ix0rai ix0rai added the enhancement New feature or request label May 29, 2024
@ix0rai ix0rai linked an issue May 29, 2024 that may be closed by this pull request
crashes server on 1.20.6 after jumping #3
Closed
@ix0rai
Copy link
Member

ix0rai commented May 29, 2024

what happened to the missing field error?

@orifu
Copy link
Member Author

orifu commented May 29, 2024

what happened to the missing field error?

getBoundingBox was changed to take a pose (i used .getPose()) but i think the returned box was centred around the origin? i can look into it more

@orifu
Copy link
Member Author

orifu commented May 29, 2024

i replaced getBoundingBox with getBounds which (i think) is used for suffocation, pushing, and probably some other stuff

@orifu
Copy link
Member Author

orifu commented May 29, 2024

actually they might just be the same method? idk im running in circles QuiltMC/quilt-mappings@f8a4394#diff-2317f530cef9407ee047c4c5c146d927e9c8aab223817d27de500736542dac38

@orifu
Copy link
Member Author

orifu commented May 29, 2024

yeah the old method m_idziptjx was removed in 24w03a (QuiltMC/quilt-mappings@c8cfac4#diff-2317f530cef9407ee047c4c5c146d927e9c8aab223817d27de500736542dac38) and was replaced with m_lgqlkcep (theyre both getBoundingBox()Lnet/minecraft/world/phys/AABB;) and then mapped in the above commit you did. so. theyre the same method. basically

@ix0rai ix0rai merged commit df4dbf7 into rosebudmods:master May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ix0rai ix0rai ix0rai approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crashes server on 1.20.6 after jumping
2 participants
@orifu @ix0rai