Allow build metadata in the version string by appending a plus sign #370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the version conventions check regular expression to allow for version strings with build metadata values.
Build metadata values are version strings with appended plus signs and a series of dot separated identifiers immediately following the patch or pre-release version. For example
1.0.0+build.001
. See the semantic versioning doc bullet 10 (here) for more details. Note, version strings with build metadata values are valid versions forpip
.Alternatively, the regular expression could be update to use the suggested regex in the semantic version doc (here).
I use the build metadata version when I have forked a repo and want to test experimental changes that I fully package and install with the package manager. It is nice to use the build metadata version value so there are not any version conflicts from upstream updated version values. In order to do this I need to update the
catkin_pkg
package repo with this change so thatcolcon build
does not error out.