Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build metadata in the version string by appending a plus sign #370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rowoflo
Copy link

@rowoflo rowoflo commented Aug 30, 2024

This PR changes the version conventions check regular expression to allow for version strings with build metadata values.

Build metadata values are version strings with appended plus signs and a series of dot separated identifiers immediately following the patch or pre-release version. For example 1.0.0+build.001. See the semantic versioning doc bullet 10 (here) for more details. Note, version strings with build metadata values are valid versions for pip.

Alternatively, the regular expression could be update to use the suggested regex in the semantic version doc (here).

I use the build metadata version when I have forked a repo and want to test experimental changes that I fully package and install with the package manager. It is nice to use the build metadata version value so there are not any version conflicts from upstream updated version values. In order to do this I need to update the catkin_pkg package repo with this change so that colcon build does not error out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant