Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esmval fixes #88

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Esmval fixes #88

wants to merge 7 commits into from

Conversation

ellesmith88
Copy link
Collaborator

No description provided.

@ellesmith88
Copy link
Collaborator Author

ellesmith88 commented Jun 14, 2021

It would probably make sense to update fixes where the operands are a list of dicts, to just be a dictionary (and update as needed in roocs/daops#40).

e.g. change

{"attrs": [ {"long_name": "Dissolved Oxygen Concentration"},        
          {"standard_name": "mole_concentration_of_dissolved_molecular_oxygen_in_sea_water"} ]    
}

to

{"attrs": {"long_name": "Dissolved Oxygen Concentration",        
           "standard_name": "mole_concentration_of_dissolved_molecular_oxygen_in_sea_water"}        
}

This is what I have used with subsequent fixes e.g. for decadal data. This also requires the fixes to be updated in the elasticsearch fix store.

EDIT: I have made this change

@ellesmith88 ellesmith88 force-pushed the master branch 2 times, most recently from 9a3b997 to c9f2d70 Compare June 21, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant