-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ronin compress
command
#184
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,163 @@ | ||
# frozen_string_literal: true | ||
# | ||
# Copyright (c) 2006-2023 Hal Brodigan (postmodern.mod3 at gmail.com) | ||
# | ||
# Ronin is free software: you can redistribute it and/or modify | ||
# it under the terms of the GNU General Public License as published by | ||
# the Free Software Foundation, either version 3 of the License, or | ||
# (at your option) any later version. | ||
# | ||
# Ronin is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU General Public License | ||
# along with Ronin. If not, see <https://www.gnu.org/licenses/>. | ||
# | ||
|
||
require 'ronin/cli/string_methods_command' | ||
require 'ronin/support/compression' | ||
require 'ronin/support/archive' | ||
|
||
module Ronin | ||
class CLI | ||
module Commands | ||
# | ||
# Compress the files. | ||
# | ||
# ## Usage | ||
# | ||
# ronin compress [option] [FILE ...] | ||
# | ||
# ## Options | ||
# | ||
# -f, --file FILE Optional file to process | ||
# --string STRING Optional string to process | ||
# -g, --gzip gzip compresses the data | ||
# -z, --zlib zlib compress the data | ||
# -n, --name Compressed file name | ||
# | ||
# ## Arguments | ||
# | ||
# [FILE ...] Optional file(s) to compress | ||
# | ||
class Compress < StringMethodsCommand | ||
usage '[options] [FILE ...]' | ||
|
||
option :gzip, short: '-g', | ||
desc: 'gzip compresses the data' do | ||
@compression_method = :gzip | ||
end | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we're going to support |
||
|
||
option :zlib, short: '-z', | ||
desc: 'zlib compress the data' do | ||
@compression_method = :zlib_deflate | ||
end | ||
|
||
option :name, short: '-n', | ||
value: { | ||
type: String | ||
}, | ||
desc: 'compressed file name' do |name| | ||
@compressed_file_name = name | ||
end | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should add an option for specifying compressed file name. |
||
|
||
description 'Compress the data' | ||
|
||
man_page 'ronin-compress.1' | ||
|
||
# | ||
# The compression format. | ||
# | ||
# @return [:gzip, :zlib_deflate] | ||
# | ||
attr_reader :compression_method | ||
|
||
# | ||
# Initializes the `ronin compress` command. | ||
# | ||
# @param [Hash{Symbol => Object}] kwargs | ||
# Additional keyword arguments. | ||
# | ||
def initialize(**kwargs) | ||
postmodern marked this conversation as resolved.
Show resolved
Hide resolved
|
||
super(**kwargs) | ||
|
||
@compression_method = :gzip | ||
end | ||
|
||
# | ||
# Runs the `compress` sub-command. | ||
# | ||
# @param [Array<String>] files | ||
# File arguments. | ||
# | ||
def run(*files) | ||
if files.empty? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought about it like if there is file given as an argument, compress it, otherwise go to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ohh.. now that I read it, it works different than i thought 😅 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm maybe it might be easier to just write all files and strings into a common Another idea would be to define separate |
||
super(*files) | ||
else | ||
raise "Files can be compressed using gzip only" if @compression_method != :gzip | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we could support compressing files using |
||
|
||
Ronin::Support::Compression.gzip(compressed_file_name) do |gz| | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also why are there two |
||
files.each do |file| | ||
File.open(file, 'rb') do |f| | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid single letter block arguments. Rename |
||
while (chunk = f.readpartial(4096)) | ||
gz.write chunk | ||
end | ||
end | ||
rescue EOFError | ||
rescue IOError => e | ||
puts "Error reading file: #{e.message}" | ||
end | ||
end | ||
end | ||
end | ||
|
||
# | ||
# Reads and processes file. | ||
# | ||
# @param [String] path | ||
# The path to the file. | ||
# | ||
def process_file(file) | ||
raise "Files can be compressed using gzip only" if @compression_method != :gzip | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we raise an error, or just print some message and return? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Call |
||
|
||
Ronin::Support::Compression.gzip(compressed_file_name) do |gz| | ||
File.open(file, 'rb') do |f| | ||
while (chunk = f.readpartial(4096)) | ||
gz.write chunk | ||
end | ||
end | ||
rescue EOFError | ||
rescue IOError => e | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rubocop does not like empty rescue :/ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ideally, there should be no IO errors when reading the file. I suspect |
||
puts "Error reading file: #{e.message}" | ||
end | ||
end | ||
postmodern marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# | ||
# Compress the string. | ||
# | ||
# @param [String] string | ||
# The input string. | ||
# | ||
# @return [String] | ||
# The compressed string. | ||
# | ||
def process_string(string) | ||
string.send(@compression_method) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I try to avoid calling the monkey-patched methods when possible. Might be better to do |
||
end | ||
|
||
private | ||
|
||
# | ||
# The compressed file name. | ||
# | ||
# @return String | ||
# | ||
def compressed_file_name | ||
@compressed_file_name || "ronin_compressed_#{Time.now.to_i}.gz" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd get rid of the timestamp, or maybe add an option for it. I think a |
||
end | ||
end | ||
end | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we only want to support processing files, then probably want to inherit from
FileProcessorCommand
, and define aprocess_input(io)
method to compress the input File or fromstdin
.If we do want to support accepting arbitrary Strings (ex:
ronin compress --string "hello world"
), then we should inherit fromStringProcessorCommand
.StringMethodsCommand
is more meant to be used by commands which simply map options to certain monkey-patch methods that are added toString
(ex:ronin decode --base64
->String#base64_decode
).