Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more Tests for Moving Histogram Algorithm #773

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Added more Tests for Moving Histogram Algorithm #773

merged 1 commit into from
Aug 1, 2024

Conversation

spran180
Copy link

@spran180 spran180 commented Jul 31, 2024 •
edited
Loading

Fixes #752

  • Added unit test for T = float.
  • Added unit test for cases when range min and max are negative.
  • Added unit test for case when window length is equal to one.
  • Added unit test for case when there are multiple values in every bin.
  • Added unit test to see bins change when window is moved.
  • Added unit test for out of bounds values.

@github-actions github-actions bot added the contribution A pull-request by someone else except maintainers label Jul 31, 2024
@spran180 spran180 changed the title Added more for Moving Histogram Algorithm Added more Tests for Moving Histogram Algorithm Jul 31, 2024
@spran180 spran180 marked this pull request as draft July 31, 2024 04:36
@github-actions github-actions bot added the work in progress Pull request is still in progress and changing label Jul 31, 2024
@spran180 spran180 marked this pull request as ready for review July 31, 2024 07:47
@github-actions github-actions bot added ready for review Pull request can be reviewed and removed work in progress Pull request is still in progress and changing labels Jul 31, 2024
@gavv gavv added this to the next milestone Aug 1, 2024
@gavv gavv force-pushed the mov-histogram-test branch from a901489 to 6d91f89 Compare August 1, 2024 12:55
@gavv gavv merged commit b102bb7 into roc-streaming:develop Aug 1, 2024
1 check passed
@github-actions github-actions bot removed the ready for review Pull request can be reviewed label Aug 1, 2024
@gavv
Copy link
Member

gavv commented Aug 1, 2024

Thank you!

A few cosmetic fixes: 2314fa4

@spran180 spran180 deleted the mov-histogram-test branch August 7, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
contribution A pull-request by someone else except maintainers
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
2 participants
@spran180 @gavv