Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic latency adjustment #688 #733

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Dynamic latency adjustment #688 #733

merged 1 commit into from
Jul 25, 2024

Conversation

baranovmv
Copy link
Member

@baranovmv baranovmv commented Jun 19, 2024 •
edited by gavv
Loading

Actual latency tuning code together
with related API and CLI parameters.

#688

@baranovmv baranovmv requested a review from gavv June 19, 2024 19:22
@github-actions github-actions bot added the ready for review Pull request can be reviewed label Jun 19, 2024
@baranovmv baranovmv force-pushed the feature/jitter_calc branch 2 times, most recently from 14ffacb to a63b11b Compare June 19, 2024 19:41
@github-actions github-actions bot added the needs rebase Pull request has conflicts and should be rebased label Jun 20, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@gavv gavv force-pushed the feature/jitter_calc branch from a63b11b to 80f392f Compare June 20, 2024 12:24
@github-actions github-actions bot removed the needs rebase Pull request has conflicts and should be rebased label Jun 20, 2024
gavv
gavv reviewed Jun 20, 2024
View reviewed changes
src/internal_modules/roc_rtp/link_meter.h Outdated Show resolved Hide resolved
src/internal_modules/roc_audio/latency_monitor.h Outdated Show resolved Hide resolved
src/internal_modules/roc_pipeline/receiver_session.cpp Outdated Show resolved Hide resolved
src/internal_modules/roc_rtp/link_meter.h Outdated Show resolved Hide resolved
src/tests/roc_fec/test_writer_reader.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the needs rebase Pull request has conflicts and should be rebased label Jun 22, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@gavv gavv force-pushed the feature/jitter_calc branch from 80f392f to 0f6b970 Compare June 22, 2024 17:14
@github-actions github-actions bot removed the needs rebase Pull request has conflicts and should be rebased label Jun 22, 2024
@baranovmv baranovmv force-pushed the feature/jitter_calc branch 3 times, most recently from b56c9e4 to 878468e Compare July 2, 2024 20:31
@gavv gavv added review in progress Pull request is being reviewed and removed ready for review Pull request can be reviewed labels Jul 7, 2024
gavv
gavv reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@gavv gavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive, here are my boring comments

src/tools/roc_recv/cmdline.ggo Show resolved Hide resolved
src/tools/roc_recv/cmdline.ggo Outdated Show resolved Hide resolved
src/internal_modules/roc_rtp/link_meter.cpp Outdated Show resolved Hide resolved
src/internal_modules/roc_packet/ilink_meter.h Show resolved Hide resolved
src/internal_modules/roc_rtp/link_meter.h Show resolved Hide resolved
src/internal_modules/roc_audio/latency_tuner.cpp Outdated Show resolved Hide resolved
src/internal_modules/roc_audio/latency_tuner.cpp Show resolved Hide resolved
src/internal_modules/roc_audio/latency_tuner.cpp Outdated Show resolved Hide resolved
src/internal_modules/roc_audio/latency_tuner.cpp Outdated Show resolved Hide resolved
src/internal_modules/roc_rtp/link_meter.cpp Outdated Show resolved Hide resolved
@gavv gavv added needs revision Pull request should be revised by its author and removed review in progress Pull request is being reviewed labels Jul 8, 2024
@gavv gavv added this to the next milestone Jul 8, 2024
@github-actions github-actions bot added the needs rebase Pull request has conflicts and should be rebased label Jul 17, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@gavv gavv force-pushed the feature/jitter_calc branch 2 times, most recently from 564650d to a5e3f27 Compare July 19, 2024 10:24
@github-actions github-actions bot removed the needs rebase Pull request has conflicts and should be rebased label Jul 19, 2024
@baranovmv baranovmv force-pushed the feature/jitter_calc branch 2 times, most recently from f5bb60d to 00b7854 Compare July 25, 2024 15:04
@gavv gavv force-pushed the feature/jitter_calc branch from 00b7854 to 7cf0475 Compare July 25, 2024 18:14
@gavv gavv merged commit 4eb79f8 into roc-streaming:develop Jul 25, 2024
@gavv gavv removed the needs revision Pull request should be revised by its author label Jul 25, 2024
@gavv
Copy link
Member

gavv commented Jul 25, 2024

Follow ups:

In upcoming days I plan to finish min/max/tolerance handling.

@gavv
Copy link
Member

gavv commented Jul 31, 2024

A few more commits:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavv gavv gavv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
2 participants
@baranovmv @gavv