Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't catch Lwt.Canceled exceptions in read #53

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

reynir
Copy link
Contributor

@reynir reynir commented Jan 17, 2025

In the logs I saw this after a stalled build. I think there are more issues around, but this fixes the spurious error log message.

Jan 17 10:40:52 poudriere daemon[711]: builder-server: [WARNING] ab873583-1d75-43c4-b973-d3f54ab4aaf7 timeout after 3600.000000 seconds
Jan 17 10:40:52 poudriere daemon[711]: builder-server: [ERROR] Error while reading: Lwt.Resolution_loop.Canceled
Jan 17 10:40:52 poudriere daemon[711]: builder-server: [WARNING] ab873583-1d75-43c4-b973-d3f54ab4aaf7 communication failure error in read with name builder-web, opam builder-web, job 127.0.2.2:18886 put back
Jan 17 10:40:52 poudriere daemon[711]: builder-server: [WARNING] ab873583-1d75-43c4-b973-d3f54ab4aaf7 timed out
Jan 17 10:40:52 poudriere daemon[711]: builder-server: [ERROR] no job found for uuid ab873583-1d75-43c4-b973-d3f54ab4aaf7

@reynir
Copy link
Contributor Author

reynir commented Jan 17, 2025

So it seems on timeout reading fails due to it catching the Canceled exception. Then due to reading failed the job is rescheduled. This makes the call to job_finished fail because the job is not to be found in state.running anymore so the timeout is never reported back /o\

@reynir reynir force-pushed the timeout-canceled-exception branch from f46af30 to e0d8924 Compare January 17, 2025 15:47
@reynir reynir merged commit a17062a into main Jan 17, 2025
1 check was pending
@reynir reynir deleted the timeout-canceled-exception branch January 17, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant