Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parsing): SubMysteryGift missing tag during SUBtember #216

Merged
merged 4 commits into from
Oct 26, 2024

Conversation

Larandar
Copy link
Contributor

  • Tag msg-param-sender-count is missing during (some?) promotions
  • Only seen with sender twitch, therefore handled as an edge case
  • If sent by twitch and the tag is missing, then assume u64::MAX

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

@Larandar
Copy link
Contributor Author

See issue #215 for my initial report

@RAnders00
Copy link
Collaborator

I propose, since a breaking release is upcoming anyways, to change the datatype toOption<u64>? I find it to be clearer and less error-prone (on the library user side). The documentation on the field should explain when the field is typically set and when it typically isn‘t set (subtember and from Twitch).

@Larandar
Copy link
Contributor Author

Larandar commented Oct 5, 2024

Since I was an outsider contributing, I was reticent to introduce a breaking change. But it is indeed the best way to handle it :)

- Tag `msg-param-sender-count` is missing during (some?) promotions
- Only seen with sender twitch, therefore handled as an edge case
- If sent by twitch and the tag is missing, then assume u64::MAX
…sterygift and anonsubmysterygift as it not anymore
@RAnders00 RAnders00 enabled auto-merge (squash) October 26, 2024 12:41
@RAnders00 RAnders00 merged commit 5996f13 into robotty:master Oct 26, 2024
8 checks passed
@RAnders00
Copy link
Collaborator

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants