Improve popup handling #53
Conversation
Signed-off-by: Luca Giorgi <[email protected]>
Signed-off-by: Luca Giorgi <[email protected]>
Signed-off-by: Luca Giorgi <[email protected]>
|
Looks like the teardown failed because no browser was open Am I misunderstanding what the |
| # Check if a popup exists | ||
| ${accept} = Get WebElements xpath:${JL_POPUP} | ||
| # Click the right most button of the popup | ||
| Run Keyword If ${accept} Click Element xpath:${JL_POPUP}/button[last()] |
There was a problem hiding this comment.
the ordering of buttons is not as indicative as their semantic classes. the "blue" one should have the jp-mod-accept or whatever.
There was a problem hiding this comment.
This is not enough to correctly identify the button we want to use. As an example, the popup for saving changes to a file has the jp-mod-accept class on both the Discard and Save buttons.
There was a problem hiding this comment.
I have kept using the position of the button for now, since that is consistent in all cases I've seen. Perhaps we should raise a bug to jupyter for the usage of jp-mod-accept?
|
Thanks for the review, I'll have to fix it up after the holidays though. Have a nice end of year! |
Signed-off-by: Luca Giorgi <[email protected]>
Signed-off-by: Luca Giorgi <[email protected]>
|
@bollwyvl have you had a chance to look at the latest commits? |
| @@ -38,6 +38,9 @@ ${JLAB XP NB FRAG} ${JLAB XP MAIN AREA FRAG}\[contains(@cla | |||
| ${JLAB XP NB TOOLBAR FRAG} [contains(@class, 'jp-NotebookPanel-toolbar')] | |||
| ${JLAB XP NB TOOLBAR} //div${JLAB XP NB TOOLBAR FRAG} | |||
| ${JLAB XP BUSY KERNEL} //*[local-name() = 'div' and contains(@class, 'jp-FilledCircleIcon' or (local-name() = 'svg' and contains(@data-icon, 'ui-components:circle-filled')))] | |||
| ${JLAB XP CONTENT XPATH} //div[contains(@class,"p-DockPanel-tabBar")]/ul[@class="p-TabBar-content"] | |||
| ${JLAB XP NOT SELECTED XPATH} ${JLAB XP CONTENT XPATH}/li[not(contains(@class,"p-mod-current"))] | |||
| ${JLAB POPUP} //div[contains(concat(' ',normalize-space(@class),' '),' jp-Dialog-footer ')] | |||
There was a problem hiding this comment.
please add the JLAB XP to this to distinguish it from the CSS selectors
Signed-off-by: Luca Giorgi [email protected]
This PR fixes the bug identified in #44