Remove ECS0200 suppression and update WellKnownTypes to not trigger ECS0600

src/Analyzers/ConstructorArgumentsShouldMatchAnalyzer.cs

@@ -205,18 +205,18 @@
             return;
         }
 
-        switch (genericNameSyntax.Identifier.Value)
+        if (genericNameSyntax.Identifier.Value is not string genericNameSyntaxIdentifierValue)
         {
-            case WellKnownTypeNames.Create:
-                AnalyzeInvocation(context, invocationExpressionSyntax, WellKnownTypeNames.MockFactory, true, true);
-                break;
-
-            case WellKnownTypeNames.Of:
-                AnalyzeInvocation(context, invocationExpressionSyntax, WellKnownTypeNames.MockName, false, true);
-                break;
+            return;
+        }
 
-            default:
-                return;
+        if (string.Equals(genericNameSyntaxIdentifierValue, WellKnownTypeNames.Create, StringComparison.Ordinal))
+        {
+            AnalyzeInvocation(context, invocationExpressionSyntax, WellKnownTypeNames.MockFactory, true, true);
+        }
+        else if (string.Equals(genericNameSyntaxIdentifierValue, WellKnownTypeNames.Of, StringComparison.Ordinal))
+        {
+            AnalyzeInvocation(context, invocationExpressionSyntax, WellKnownTypeNames.Mock, false, true);
         }
     }
 
@@ -286,7 +286,7 @@
         // Quick check
         if (!string.Equals(
                 genericNameSyntax.Identifier.ValueText,
-                WellKnownTypeNames.MockName,
+                WellKnownTypeNames.Mock,
                 StringComparison.Ordinal))
         {
             return;

src/Common/MoqMethodDescriptorBase.cs

@@ -12,7 +12,7 @@
 internal abstract class MoqMethodDescriptorBase
 {
     private static readonly string ContainingNamespace = WellKnownTypeNames.Moq;
-    private static readonly string ContainingType = WellKnownTypeNames.MockName;
+    private static readonly string ContainingType = WellKnownTypeNames.Mock;
 
     public abstract bool IsMatch(SemanticModel semanticModel, MemberAccessExpressionSyntax memberAccessSyntax, CancellationToken cancellationToken);
 

src/Common/WellKnownTypeNames.cs

@@ -1,18 +1,16 @@
 namespace Moq.Analyzers.Common;
 
-#pragma warning disable ECS0200 // Consider using readonly instead of const for flexibility
-
 internal static class WellKnownTypeNames
 {
-    internal const string Moq = nameof(Moq);
-    internal const string MockName = "Mock";
-    internal const string MockBehavior = nameof(MockBehavior);
-    internal const string MockFactory = nameof(MockFactory);
-    internal const string MoqMock = $"{Moq}.{MockName}";
-    internal const string MoqMock1 = $"{MoqMock}`1";
-    internal const string MoqBehavior = $"{Moq}.{MockBehavior}";
-    internal const string MoqRepository = $"{Moq}.MockRepository";
-    internal const string As = nameof(As);
-    internal const string Create = nameof(Create);
-    internal const string Of = nameof(Of);
+    internal static readonly string Moq = nameof(Moq);
+    internal static readonly string Mock = nameof(Mock);
+    internal static readonly string MockBehavior = nameof(MockBehavior);
+    internal static readonly string MockFactory = nameof(MockFactory);
+    internal static readonly string MoqMock = $"{Moq}.{Mock}";
+    internal static readonly string MoqMock1 = $"{MoqMock}`1";
+    internal static readonly string MoqBehavior = $"{Moq}.{MockBehavior}";
+    internal static readonly string MoqRepository = $"{Moq}.MockRepository";
+    internal static readonly string As = nameof(As);
+    internal static readonly string Create = nameof(Create);
+    internal static readonly string Of = nameof(Of);
 }