Skip to content

Commit

Permalink
Move "upload binlogs" CI step earlier in pipeline and run even if fai…
Browse files Browse the repository at this point in the history
…led (#273)

Currently, the "upload binlogs" step is too far down in the CI pipeline
(and also doesn't run if the build fails). Move it up a bit so that the
order of log upload mirrors the order of actions and add `success() ||
failure()` so they are uploaded even during build failures.
  • Loading branch information
MattKotsenas authored Nov 25, 2024
1 parent fcfd7e4 commit ac86356
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,14 @@ jobs:
- name: Test
run: dotnet test --no-build --configuration Release --settings ./build/targets/tests/test.runsettings

- name: Upload binlogs
uses: actions/upload-artifact@v4
if: success() || failure()
with:
name: binlogs-${{ matrix.os }}
path: ./artifacts/logs
if-no-files-found: error

- name: Upload *.received.* files
uses: actions/upload-artifact@v4
if: failure()
Expand Down Expand Up @@ -107,13 +115,6 @@ jobs:
project-token: ${{ secrets.CODACY_PROJECT_TOKEN }}
coverage-reports: ${{ github.workspace }}/artifacts/TestResults/coverage/Cobertura.xml

- name: Upload binlogs
uses: actions/upload-artifact@v4
with:
name: binlogs-${{ matrix.os }}
path: ./artifacts/logs
if-no-files-found: error

- name: Upload packages
uses: actions/upload-artifact@v4
with:
Expand Down

0 comments on commit ac86356

Please sign in to comment.