Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph widget - do not print basic block address - Fixed #3150

Closed
wants to merge 1 commit into from
Closed

Graph widget - do not print basic block address - Fixed #3150

wants to merge 1 commit into from

Conversation

M-ismail-ramzan
Copy link

Checklist for this pull request

Detailed description

To make these changes, I removed the lines that were responsible for rendering the "Extra Address" section, and I also removed the lines that were increasing the height of the graph block.

Test plan (required)
I have converted the design from taking up extra space on the screen (see image 1) to the design with a reduced block height, which saves space on the screen (see image 2).

Image 1
image

Image 2
image

Code formatting
Make sure you ran clang-format on your code before making the PR. Check our contribution guidelines here: https://cutter.re/docs/contributing/code/getting-started.html -->

Closing issues
This pull request closes issue #3144.

@M-ismail-ramzan M-ismail-ramzan changed the title Graph widget - do not print basic block address - Fixed Graph widget - do not print basic block address - Fixed Mar 25, 2023
@XVilka
Copy link
Member

XVilka commented Mar 27, 2023

It still should be shown if the graph.offsets option is unset, since there should be no offsets printed by default for every instruction. See the comment to the original issue on details.

@M-ismail-ramzan
Copy link
Author

It still should be shown if the graph.offsets option is unset, since there should be no offsets printed by default for every instruction. See the comment to the original issue on details.

Alright, Am working on it.

@M-ismail-ramzan M-ismail-ramzan closed this by deleting the head repository Mar 29, 2023
@M-ismail-ramzan
Copy link
Author

Kindly see #3154 for further Updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants