Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RV32 Zcherilevels ACPERM #440

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix RV32 Zcherilevels ACPERM #440

merged 2 commits into from
Nov 6, 2024

Conversation

tariqkurd-repo
Copy link
Collaborator

@tariqkurd-repo tariqkurd-repo commented Nov 5, 2024 •
edited
Loading

This version has been verified by a python script which checks all possible combinations of removing permissions from maximum permissions

additional fix for #428

@tariqkurd-repo
Copy link
Collaborator Author

The modifications should have been for RV32 only, so this needs fixing

arichardson
arichardson reviewed Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these constraints should be scoped to RV32 but it looks sensible to me. The logic should be folded to something simpler anyway so I don't think it's a huge problem that these clauses are getting somewhat complex.

@tariqkurd-repo tariqkurd-repo merged commit b7c9d7e into riscv:main Nov 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamie-melling jamie-melling jamie-melling left review comments

@arichardson arichardson arichardson approved these changes

@LawrenceEsswood LawrenceEsswood Awaiting requested review from LawrenceEsswood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tariqkurd-repo @arichardson @jamie-melling