Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make permission bit order consistent #36

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Timmmm
Copy link
Contributor

@Timmmm Timmmm commented Jan 24, 2024

Use the same ordering for permission bits in the RV64 encoding as in CAndPerms etc.

Fixes #25

Copy link
Collaborator

@tariqkurd-repo tariqkurd-repo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't do it this way

src/cap-description.adoc Outdated Show resolved Hide resolved
@Timmmm Timmmm force-pushed the user/timh/permission_bit_order branch from 9a00561 to d56fda3 Compare January 24, 2024 15:24
src/cap-description.adoc Outdated Show resolved Hide resolved
Use the same ordering for permission bits in CAndPerms as in the RV64 encoding.

Fixes riscv#25
@Timmmm Timmmm force-pushed the user/timh/permission_bit_order branch from d56fda3 to 69d9353 Compare January 25, 2024 11:21
@Timmmm
Copy link
Contributor Author

Timmmm commented Jan 25, 2024

Updated so that CAndPerm matches the RV64 encoding.

@andresag01 andresag01 merged commit 0c7d900 into riscv:main Jan 25, 2024
2 checks passed
@Timmmm Timmmm deleted the user/timh/permission_bit_order branch January 25, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permission encoding order mismatch
3 participants