Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft specification proposal from Codasip #2

Merged
merged 5 commits into from
Jan 20, 2024

Conversation

andresag01
Copy link
Collaborator

This change is a draft proposal with CHERI extensions for RISC-V. These are the following extensions being proposed:

  • Zcheri_purecap: Introduces key, minimal CHERI concepts and features to the RISC-V ISA. The resulting extended ISA is not backwards-compatible with RISC-V
  • Zcheri_legacy: Extends Zcheri_purecap with features to ensure that the ISA extended with CHERI allows backwards binary compatibility with RISC-V
  • Zcheri_mode: Adds a mode bit in the encoding of capabilities to allow changing the current CHERI execution mode using indirect jump instructions
  • Zcheri_pte: CHERI extension for RISC-V harts supporting page-based virtual-memory

@tariqkurd-repo @arichardson

@tariqkurd-repo tariqkurd-repo self-requested a review January 12, 2024 12:30
Copy link
Collaborator

@tariqkurd-repo tariqkurd-repo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document is the culmination of many months of work from several people.
I'd like @arichardson to merge it if he's happy.
The SAIL inserts are missing, otherwise I think it's quite complete as a techncial specification.

Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR! I've started reviewing it and will leave comments shortly. I think we can probably merge the initial version and send it out for review before those have been addressed but I'd like to finish reading the entire document before I click merge.

@tariqkurd-repo
Copy link
Collaborator

No problem @arichardson , best to read the whole thing before merging, and then we can start discussing. This is a live spec so having it merged will make fixing issues easier.

@vmurali
Copy link

vmurali commented Jan 17, 2024

Hi all, is github PR comments the forum to discuss the spec?

@tariqkurd-repo
Copy link
Collaborator

I hope we can merge by the end of this week and then start filing issues and PRs for discussion. @arichardson is reading the whole spec first.

@arichardson
Copy link
Collaborator

I am almost done with my readthrough and plan to merge by the end of this week. So far I've only spotted minor issues that can be fixed incrementally.

@vmurali
Copy link

vmurali commented Jan 17, 2024

No hurry! I was just asking where one should be discussing the spec as this is the first major PR after the initial commit, and no issues have been reported so far in this repo.

Looks like the suggested approach for comments/discussion is via this repo's issues and submitting PR's.

Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my read of the spec and just wanted to say this is fantastic work!

I have some smaller comments that I'll file as GitHub issues of the coming days, but nothing that should block merging this initial version.

@arichardson arichardson merged commit 66b77c4 into riscv:main Jan 20, 2024
1 check passed
tariqkurd-repo added a commit to tariqkurd-repo/riscv-cheri that referenced this pull request Sep 17, 2024
andresag01 pushed a commit to tariqkurd-repo/riscv-cheri that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants