-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add draft specification proposal from Codasip #2
Add draft specification proposal from Codasip #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This document is the culmination of many months of work from several people.
I'd like @arichardson to merge it if he's happy.
The SAIL inserts are missing, otherwise I think it's quite complete as a techncial specification.
fix cincoffsetimm encoding specification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR! I've started reviewing it and will leave comments shortly. I think we can probably merge the initial version and send it out for review before those have been addressed but I'd like to finish reading the entire document before I click merge.
No problem @arichardson , best to read the whole thing before merging, and then we can start discussing. This is a live spec so having it merged will make fixing issues easier. |
Hi all, is github PR comments the forum to discuss the spec? |
I hope we can merge by the end of this week and then start filing issues and PRs for discussion. @arichardson is reading the whole spec first. |
I am almost done with my readthrough and plan to merge by the end of this week. So far I've only spotted minor issues that can be fixed incrementally. |
No hurry! I was just asking where one should be discussing the spec as this is the first major PR after the initial commit, and no issues have been reported so far in this repo. Looks like the suggested approach for comments/discussion is via this repo's issues and submitting PR's. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed my read of the spec and just wanted to say this is fantastic work!
I have some smaller comments that I'll file as GitHub issues of the coming days, but nothing that should block merging this initial version.
This change is a draft proposal with CHERI extensions for RISC-V. These are the following extensions being proposed:
@tariqkurd-repo @arichardson