Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitmodules to reflect LLVM bump to 18.1 #1612

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

JohRust
Copy link
Contributor

@JohRust JohRust commented Nov 7, 2024

Fixes #1611
The LLVM submodule was updated to 18.1 in commit 97fce6f and now points to https://github.com/llvm/llvm-project/tree/3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff. Make .gitmodules point to that branch as well.

The LLVM submodule was updated to 18.1 in commit 97fce6f and now points to https://github.com/llvm/llvm-project/tree/3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff, the latest commit of branch release/18.x. However .gitmodules still referred to branch 17.x.

Signed-off-by: Johannes Rust <[email protected]>
@TommyMurphyTM1234
Copy link
Collaborator

TommyMurphyTM1234 commented Nov 7, 2024

LGTM - thanks. 👍

Just for completeness/reference purposes the previous PR bumping LLVM but forgetting to update .gitmodules is here:

Copy link
Collaborator

@cmuellner cmuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cmuellner cmuellner merged commit 444c01e into riscv-collab:master Nov 7, 2024
26 checks passed
@JohRust JohRust deleted the update_llvm_gitmodule branch November 8, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.gitmodules does not reflect changes in LLVM submodule
3 participants