Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump musl from v1.2.2 to v1.2.5 #1568

Merged

Conversation

TommyMurphyTM1234
Copy link
Collaborator

As with Linux/uClibc:

the riscv-gnu-toolchain Makefile[.in] is not set up to facilitate the running of the test suite for the Linux/musl toolchain so this bumping of the submodule version can only be done "blindly" right now.

Copy link
Collaborator

@cmuellner cmuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmuellner
Copy link
Collaborator

Thanks for the PR!

I've double-checked the commit/tag and the CI is happy.

@cmuellner cmuellner merged commit cc92ae9 into riscv-collab:master Oct 9, 2024
20 checks passed
@TommyMurphyTM1234
Copy link
Collaborator Author

TommyMurphyTM1234 commented Oct 9, 2024

Thanks @cmuellner. 👍

musl v1.2.5 also now supports RV32:

musl-1.2.5.tar.gz (sig) - February 29, 2024
This release adds extension functions statx and preadv2/pwritev2, with fallback implementations for older kernels, and adds two new ports: loongarch64 and riscv32. Minor changes to the printf family of functions have been made for conformance to new standards interpretations/requirements. TLSDESC support for riscv64 has also been added.

so the limitation imposed by this commit is no longer required:

I may prepare a PR to remove this limitation if that's OK?

Curiously, some work to allow an RV32 build of the Linux/musl toolchain was done a long time ago even though musl presumably didn't support RV32 at the time which is odd...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants