Add stage2 and other dependencies for check-glibc-linux. #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmuellner
approved these changes
Nov 28, 2023
|
Small nit (no need to update this PR): the subject (first) line of a git commit usually does not end with a period ( |
Some glibc tests like tst-unwind-{main,ctor} depends on stage2 artifacts
(in particular, GCC runtime libs) to be properly installed. Add stage2
dependencies to avoid these tests from spuriously failing.
The test suite also uses the simulator and Deja GNU, both of which were
not declared as dependencies, so add them as well.
Closes: riscv-collab#1379
ishitatsuyuki
force-pushed
the
glibc-check-stage2
branch
from
3dad76e to
7e040d7
Compare
|
Dejagnu's git server seems to be having issues which is causing the CI to fail. |
|
I checked the error log it seems due to clone error, but the repo info is right here: http://savannah.gnu.org/git/?group=dejagnu Maybe we need to try re-run the CI again, thanks. If there also exist the same problem, you can try to change the |
|
Merged as CI is happy after retriggering the builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some glibc tests like tst-unwind-{main,ctor} depends on stage2 artifacts (in particular, GCC runtime libs) to be properly installed. Add stage2 dependencies to avoid these tests from spuriously failing.
The test suite also uses the simulator and Deja GNU, both of which were not declared as dependencies, so add them as well.
Closes: #1379