Remove parent's DEJAGNU
environment variable
#1377
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make report
/make check
on riscv-gnu-toolchain depends on the default installation of DejaGnu'sriscv-sim.exp
.If an user overrides the DejaGnu environment with custom
riscv-sim.exp
, many tricks used in the testing framework in riscv-gnu-toolchain stops working.I noticed this issue while testing riscv-gnu-toolchain with an environment which I use custom DejaGnu configuration to test GCC (alone) with QEMU + custom arguments (written in
$DIR/boards/riscv-sim.exp
whereDEJAGNU=$DIR/site.exp
).So, this commit removes parent's
DEJAGNU
environment variable byunexport
ing it.Note that
unexport
is a feature of GNU Make and (before approving) check whether using a "not in POSIX make" feature is appropriate for this project.