Add dependency to Python package installation when SIM=spike
#1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `scripts/wrapper/spike/*` started to use the script `scripts/march-to-cpu-opt`, we need to add dependency to the prerequisite of this script (installation of pyelftools). This commit adds the dependency to `stamps/install-python-package`.
|
Same comment as #1374 (comment): This proposal looks reasonable (no objections at all). Still, I want to make a counter proposal: remove the package installation from |
cmuellner
approved these changes
Nov 28, 2023
|
Closing this as we merged #1381 instead (long ago). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
scripts/wrapper/spike/*started to use the scriptscripts/march-to-cpu-opt, we need to add dependency to the prerequisite of this script (installation of pyelftools).This commit adds the dependency to
stamps/install-python-package.