Skip to content

Commit

Permalink
Merge branch 'Davidrums-master'
Browse files Browse the repository at this point in the history
  • Loading branch information
rickypc committed Sep 17, 2016
2 parents 2885ef1 + c52c3a3 commit d5df638
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 5 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
0.2.4 (2016.09.17)
==================

* Fix is_secure parameter. Thanks to @davidrums

0.2.3 (2016.01.19)
==================

Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ ImapLibrary must be imported into your Robot test suite.
.. code:: robotframework
*** Settings ***
Library ImapLibrary
Library ImapLibrary
See `Robot Framework User Guide`_ for more information.

Expand Down
2 changes: 1 addition & 1 deletion doc/ImapLibrary.html

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,12 @@
license='Apache License, Version 2.0',
classifiers=[
'Development Status :: 4 - Beta',
'Framework :: Robot Framework',
'Intended Audience :: Developers',
'Topic :: Software Development :: Testing',
'License :: OSI Approved :: Apache Software License',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3.5',
'Topic :: Software Development :: Testing',
],
keywords='robot framework testing automation imap email mail softwaretesting',
platforms='any',
Expand Down
2 changes: 1 addition & 1 deletion src/ImapLibrary/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def open_mailbox(self, **kwargs):
| Open Mailbox | host=HOST | user=USER | password=SECRET | port=8000 |
"""
host = kwargs.pop('host', kwargs.pop('server', None))
is_secure = kwargs.pop('is_secure', True)
is_secure = kwargs.pop('is_secure', 'True') == 'True'
port = int(kwargs.pop('port', self.PORT_SECURE if is_secure else self.PORT))
self._imap = IMAP4_SSL(host, port) if is_secure else IMAP4(host, port)
self._imap.login(kwargs.pop('user', None), kwargs.pop('password', None))
Expand Down
2 changes: 1 addition & 1 deletion src/ImapLibrary/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
IMAP Library - a IMAP email testing library.
"""

VERSION = '0.2.3'
VERSION = '0.2.4'


def get_version():
Expand Down

0 comments on commit d5df638

Please sign in to comment.