test vectors: additional use cases to test for #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that you are at it, could you clarify that validation should be done with the given message? It's not clear from the current working. (In the existing test cases.) |
|
Also, the two cases you added don't specify what fulfillment to validate for the two conditions you generate. The binary one or the json one. |
|
Also, another issue probably. It's unclear whether the message is encoded as UTF8, hex or base64. |
sappenin
requested changes
Sep 26, 2017
|
@stevenroose @sappenin sorry for the massive delay, will try to address the points asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A condition can be validated for its correctness, so this PR proposes to add this test to the existing list of things to test for the test vectors.
Since a Condition object may be created from two different sources: DER encoded binary and URI, checking whether the parsed Condition validates to
TRUEcan be done for both the binary and URI, hence two new things to test for.