Error.getUnsafe #123
Open
Error.getUnsafe #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsl
reviewed
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a way to get a custom property value out of an Error. Includes full documentation, warnings, and a test. This satisfies a real-world scenario of me trying to get the "code" property out of a Firebase SDK exception. See discussion in
#102.
Note there is no module to deal with
exnthat aren't subclassed Error objects; it could have gone there I guess. But I'm fine with working off Error objects.See the doc comments. I wanted to type the return value as
unknownto make this safe but there is no agreement on that right now. I think if we beef up the Type module #118 we can provide a safer and more comprehensive way of dealing with this kind of thing here and in the Object module.