Fix Intellisense menu for Error #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagaram
force-pushed
the
flattenErrorModule
branch
from
9a56378 to
2d18a18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all the submodules like
SyntaxErrorandRangeErrorthat had a single function in it -make- and moves these to the top level likemakeRangeErrorandmakeSyntaxError. This is more like the oldJs.Exnmodule and makes the Intelliense menu a lot easier to navigate. You can quickly see the types of errors you can create. It is still a 2 step process - make then raise - even though in 99% of the cases the user will throw immediately; this is a step backward from theJs.Exnmodule that hasraiseSyntaxErrorand other variants.Before:
After: