chore(preflights): replace run collector with host sysctl for ip_forwarding #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGAntunes
commented
Nov 15, 2024
| when: 'net.ipv4.ip_forward == 0' | ||
| message: "IP forwarding must be enabled. To enable it, edit /etc/sysctl.conf, add or uncomment the line 'net.ipv4.ip_forward=1', and run 'sudo sysctl -p'." | ||
| - pass: | ||
| when: 'net.ipv4.ip_forward > 0' |
There was a problem hiding this comment.
According to the docs - https://www.kernel.org/doc/html/latest/networking/ip-sysctl.html:
ip_forward - BOOLEAN
0 - disabled (default) not 0 - enabled
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
ajp-io
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Follow up to #1500 we should use the already existing
sysctlcollector for theip_forwardingcheckWhich issue(s) this PR fixes:
Does this PR require a test?
NONE
I run a manual test locally, however it's hard to reproduce with the recent changes introduced in - #1484. Instead I cherry picked the analyzer and collector and run them separately using the preflight binary:
After
sysctl net.ipv4.ip_forward=0Does this PR require a release note?
Does this PR require documentation?
NONE