fix: appkit basic multichain #3658
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or/clean-up-wc-connector
…Fix tests. Fix issue where no adapters would open regular WCconnect screen
…or/clean-up-wc-connector
…/appkit into fix/appkit-basic
|
Supersedes #3648 |
tomiir
requested review from
magiziz,
enesozturk,
zoruka and
svenvoskamp
and removed request for
zoruka,
magiziz and
enesozturk
magiziz
reviewed
Jan 15, 2025
| @@ -609,6 +610,7 @@ export class WagmiAdapter extends AdapterBlueprint { | |||
| } | |||
|
|
|||
| public override async switchNetwork(params: AdapterBlueprint.SwitchNetworkParams) { | |||
| await super.switchNetwork(params) | |||
magiziz
reviewed
Jan 15, 2025
| address, | ||
| chainId: caipNetwork.id, | ||
| chainNamespace: caipNetwork.chainNamespace | ||
| }) | ||
| } | ||
| } | ||
| } else { | ||
| this.setCaipNetwork(caipNetwork) | ||
| } catch (error) { |
There was a problem hiding this comment.
should we remove (error) part ?
zoruka
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When initializing AppKit without adapters there were 2 issues:
There's an additional issue on reloading and switching networks, where currently connected providers would not be recognized as connected.
Changes:
w3m-connect-viewto not display auth options when no adapters are presentswitchNetworklogic and delegates to adapter base class to handle special casesType of change
Associated Issues
Closes APKT-2030
Checklist