Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): encrypted field validation #33382

Merged
merged 15 commits into from
Jan 6, 2025

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Jan 3, 2025

Changes

  • Throw error if encrypted field found without privateKey & RENOVATE_X_ENCRYPTED_STRICT=true resulting in a config issue being raised

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository
  1. Self Hosted:
  1. Mend Hosted (with MEND_HOSTED=true in env)

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change, we should do it in a major version bump

@viceice viceice added the breaking Breaking change, requires major version bump label Jan 3, 2025
lib/config/validation.ts Outdated Show resolved Hide resolved
lib/config/validation.ts Outdated Show resolved Hide resolved
@justo-mend
Copy link
Collaborator

@RahulGautamSingh Some tests are failing. Are you able to get them to pass?

@justo-mend
Copy link
Collaborator

Thanks @RahulGautamSingh

@RahulGautamSingh RahulGautamSingh requested review from viceice and rarkins and removed request for rarkins January 6, 2025 16:04
lib/config/decrypt.ts Outdated Show resolved Hide resolved
rarkins
rarkins previously approved these changes Jan 6, 2025
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on real repo?

@RahulGautamSingh
Copy link
Collaborator Author

Tested on real repo?

Yes, linked in description

@RahulGautamSingh
Copy link
Collaborator Author

Also, don't think it's breaking anymore.

@rarkins rarkins added this pull request to the merge queue Jan 6, 2025
Merged via the queue into renovatebot:main with commit a67c45f Jan 6, 2025
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.91.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@justo-mend
Copy link
Collaborator

Thanks @RahulGautamSingh !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants