Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Jira templates more configurable and safer #124

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

hluk
Copy link
Member

@hluk hluk commented Nov 25, 2024

Enables configuring Jira fields and labels using a config file. Path to
the config file is set by RETASC_CONFIG environment variable.

This uses mapping for field names in template files to Jira issue
properties, because the property naming in Jira are often inconsistent
(as in camelCase, snake_case).

This also ensures that the template files only use known Jira
properties, labels contain internal ID labels and field for release name
cannot be overridden.

Uses only labels to identify issues for given release.

URLs and paths for rules and template are also taken from the config
files.

CLI command generate-schema generates schema for the config file.

JIRA: RHELWF-10977

@hluk hluk requested a review from a team as a code owner November 25, 2024 10:40
@hluk
Copy link
Member Author

hluk commented Nov 28, 2024

@zhanglu1122 Can you help review this?

Copy link
Contributor

@qgong qgong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hluk
Copy link
Member Author

hluk commented Nov 28, 2024

@qgong Thanks for your review.

I've added another change (see the latest commit) to drop setting the affectedVersion Jira field - setting it is not easy because it is a list with more complex values. But it could be possible to set it from the template files. Let me look into it later if it is really needed.

@hluk hluk force-pushed the jira-templates branch 4 times, most recently from 991058d to f20600e Compare December 3, 2024 11:22
Enables configuring Jira fields and labels using a config file. Path to
the config file is set by `RETASC_CONFIG` environment variable.

This uses mapping for field names in template files to Jira issue
properties, because the property naming in Jira are often inconsistent
(as in camelCase, snake_case).

This also ensures that the template files only use known Jira
properties, labels contain internal ID labels and field for release name
cannot be overridden.

Uses only labels to identify issues for given release.

URLs and paths for rules and template are also taken from the config
files.

CLI command `generate-schema` generates schema for the config file.

JIRA: RHELWF-10977
@hluk hluk merged commit 2beaa16 into main Dec 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants