Media page #89
Open
Media page #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace feeling-responsive js bundle by separate script tags (for transparency) - remove js files no longer needed (sheetrock, handlebars, ...) - use cdnjs when possible
- youtube - vimeo
- youtube and vimeo - to fix: media.ccc.de (iframe trouble, SAMEORIGIN)
TODO: - thumbnails - proper captions - rest of the presskit images (?) - back-to-top-buttons
- hover-effect works after replacing the svg - changed link to new-tab, because I haven't yet figured out how to embed media.ccc.de properly: the /oembed iframe works now (thanks to quick fixes by the nice folks in #voc), but looks...no nice. Horizontal stretching would be nice, and including more of the features of media.ccc.de (download, audio) -- long story short, a new window seemed like the best solution.
Speaker_Icon.svg is https://commons.wikimedia.org/wiki/File:Speaker_Icon.svg with some styles removed to make css styling work
Not sure why I missed that (must have pushed uncommited changes to dev, sorry)...
...doesn't look good on the pictures, at least with the current titles
not everyone is using binstubs, but it doesn't hurt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather big change, so let's discuss it.
The rationale for removing the theme's
javascript.[min.].jswas that working with other JS stuff requires knowing the versions what are in use, and it's tedious to grep through this file over and over again. Using cdnjs for those files felt right, why waste systemli's bandwidth.In the process, I cleaned up the JS libs what were included (e.g. sheetrock was no longer needed), and fixed the
<script>tags to accomodate for most JS libs being loaded in_includes/footer_scripts.htmljust before</body>(i.e., use$(document).ready(function(){/* ... */});Also introduced some SVG handling to use the Chaosknoten as hover-ified link icon.
I guess the labels for title, event, author (below the media icons) are not optimal. Ideas? Same goes for the
h3s for the media titles.