Add new nodejs-postgres stack #1086

jarifibrahim · 2018-11-21T08:49:30Z

What does this PR do?

In order to run multi-container booster in che (https://github.com/nodeshift-starters/nodejs-rest-http-crud) we need to add a new stack which has 2 machines, first one is the dev machine with node and the second machine has the postgres database.

What issues does this PR fix or reference?

N/A

How have you tested this PR?

Yes. I have tested this stack locally and it works as expected.

In order to run multi-container booster in che (https://github.com/nodeshift-starters/nodejs-rest-http-crud) we need to add a new stack which has 2 machines, first one is the dev machine with node and the second machine has the postgres database. Signed-off-by: Ibrahim Jarif <[email protected]>

centos-ci · 2018-11-21T09:13:43Z

@jarifibrahim The che server [build 814] has been successfully deployed.

http://rhche-prcheck-1086.devtools-dev.ext.devshift.net

jarifibrahim · 2018-11-21T11:23:46Z

The nodejs stack is failing with

Loading...
pulling image "eclipse/node"
Successfully pulled image "eclipse/node"
Created container
Started container
pulling image "registry.centos.org/postgresql/postgresql:9.6"
Successfully pulled image "registry.centos.org/postgresql/postgresql:9.6"
Error: Error response from daemon: create bf02f38276729574b6586e049129587cdeb36a951e4d1d38129ec8b8bb8a955d: error while creating volume path '/var/lib/docker/volumes/bf02f38276729574b6586e049129587cdeb36a951e4d1d38129ec8b8bb8a955d/_data': mkdir /var/lib/docker/volumes/bf02f38276729574b6586e049129587cdeb36a951e4d1d38129ec8b8bb8a955d: permission denied

How can I fix these permissions?

sbose78 · 2018-11-21T12:27:42Z

@jarifibrahim could you switch to quay.io/openshiftio/che-centos-nodejs ?

jarifibrahim · 2018-11-21T12:44:11Z

@jarifibrahim could you switch to quay.io/openshiftio/che-centos-nodejs ?

Done. See ba45c6f

centos-ci · 2018-11-21T13:20:20Z

@jarifibrahim The che server [build 815] has been successfully deployed.

http://rhche-prcheck-1086.devtools-dev.ext.devshift.net

centos-ci · 2018-11-21T16:11:07Z

@jarifibrahim The che server [build 816] failed.

Link	URL
console	https://ci.centos.org/view/Devtools/job/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/816/console
artifacts	http://artifacts.ci.centos.org/devtools/che-functional-tests/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/816/

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

ibuziuk · 2018-11-21T18:11:48Z

[test]

jarifibrahim · 2018-11-21T18:18:34Z

@ibuziuk I've changed the docker image for the Postgres and that's why the build is failing.

centos-ci · 2018-11-21T18:19:22Z

@jarifibrahim The che server [build 817] failed.

Link	URL
console	https://ci.centos.org/view/Devtools/job/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/817/console
artifacts	http://artifacts.ci.centos.org/devtools/che-functional-tests/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/817/

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

ibuziuk · 2018-11-21T18:38:22Z

[test]

ibuziuk · 2018-11-21T18:38:49Z

@jarifibrahim I do not think it is related

centos-ci · 2018-11-21T19:03:11Z

@jarifibrahim The che server [build 818] has been successfully deployed.

http://rhche-prcheck-1086.devtools-dev.ext.devshift.net

jarifibrahim · 2018-11-21T19:16:01Z

I see the same error even after changing the Postgres docker image.

jarifibrahim · 2018-11-21T19:24:11Z

The same stack runs fine on Che running via minishift locally.

ibuziuk · 2018-11-21T19:42:53Z

@jarifibrahim could you please point to the dockerfile of the postgres image used in the stack ?

jarifibrahim · 2018-11-22T07:28:36Z

@jarifibrahim could you please point to the dockerfile of the postgres image used in the stack ?

For image: lib/postgres - https://github.com/docker-library/postgres/tree/master/9.6
and for centos/postgresql-96-centos7/ - https://github.com/sclorg/postgresql-container/tree/generated/9.6

jarifibrahim · 2018-11-27T07:22:04Z

~~@sbose78 @ibuziuk Looks like volume mount doesn't work for mysql container as well https://github.com/sclorg/mysql-container/blob/master/5.7/Dockerfile#L73 because of sclorg/httpd-container#30.~~

What else can we do to get Postgres container running?

EDIT -
The above mentioned issue was related to S2I builds. We aren't dealing with S2I builds for now so it has nothing to do with this stack/PR.

sbose78 · 2018-11-27T07:58:42Z

Does this image work registry.centos.org/postgresql/postgresql:9.6 ?
I had used it in a recipe, from which I had created a workspace on che.openshift.io https://gist.github.com/sbose78/5c4ad4e3fd2fea7efb4efb3849ecdea4#file-gistfile1-txt-L24

EDIT:
(^^ ignore, you had changed it. :) )

jarifibrahim · 2018-11-27T13:03:33Z

According to openshift/origin#16211 (comment) we need to mount the volume on the specific path. @ibuziuk Is there a way to do this? I tried adding a volume via UI and updating the recipe but it doesn't seem to work.

jarifibrahim · 2018-11-28T06:50:34Z

I've raised sclorg/postgresql-container#301 to remove volume from the centos-postgresql image.

centos-ci · 2018-12-01T12:29:39Z

@jarifibrahim The che server [build 851] has been successfully deployed.

http://rhche-prcheck-1086.devtools-dev.ext.devshift.net

jarifibrahim · 2018-12-01T12:46:43Z

I managed to fix the volume issue using the correct PV claim dc8659f .
The stack works out of the box with https://github.com/nodeshift-starters/nodejs-rest-http-crud now 🎉

centos-ci · 2018-12-07T11:14:22Z

@jarifibrahim The che server [build 878] has been successfully deployed.

http://rhche-prcheck-1086.devtools-dev.ext.devshift.net

amisevsk

Thanks @jarifibrahim! I've tested the stack and it mostly works great on che.openshift.io, there is just one small change that needs to be made (see below).

On che.openshift.io, using this stack, I see volumemount claim-che-workspace, subpath workspaceakco96ccz55a4c6e/postgresdata → /var/lib/pgsql/data on the database container, which is perfect :)

assembly/fabric8-stacks/src/main/resources/stacks.json

centos-ci · 2018-12-07T16:13:27Z

@jarifibrahim The che server [build 885] has been successfully deployed.

http://rhche-prcheck-1086.devtools-dev.ext.devshift.net

jarifibrahim · 2018-12-07T16:42:27Z

Thank you so much @amisevsk. That fix worked perfectly :)

centos-ci · 2018-12-10T07:47:55Z

@jarifibrahim The che server [build 886] failed.

Link	URL
console	https://ci.centos.org/view/Devtools/job/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/886/console
artifacts	http://artifacts.ci.centos.org/devtools/che-functional-tests/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/886/

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

centos-ci · 2018-12-10T08:20:07Z

@jarifibrahim The che server [build 887] failed.

Link	URL
console	https://ci.centos.org/view/Devtools/job/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/887/console
artifacts	http://artifacts.ci.centos.org/devtools/che-functional-tests/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/887/

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

jarifibrahim · 2018-12-10T08:38:40Z

assembly/fabric8-stacks/src/main/resources/stacks.json

+                  "protocol": "http"
+                }
+              },
+              "volumes": {},


@ibuziuk @amisevsk Do we need to mount a volume here for the user data? Like /projects ?

no, project is mounted by default. No need to explicitly specify if

jarifibrahim · 2018-12-10T09:47:21Z

[test]

centos-ci · 2018-12-10T10:20:11Z

@jarifibrahim The che server [build 888] failed.

Link	URL
console	https://ci.centos.org/view/Devtools/job/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/888/console
artifacts	http://artifacts.ci.centos.org/devtools/che-functional-tests/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/888/

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

ibuziuk · 2018-12-10T10:47:02Z

[test]

centos-ci · 2018-12-10T11:14:30Z

@jarifibrahim The che server [build 890] failed.

Link	URL
console	https://ci.centos.org/view/Devtools/job/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/890/console
artifacts	http://artifacts.ci.centos.org/devtools/che-functional-tests/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/890/

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

ibuziuk · 2018-12-10T11:20:04Z

[test]

centos-ci · 2018-12-10T11:53:30Z

@jarifibrahim The che server [build 891] failed.

Link	URL
console	https://ci.centos.org/view/Devtools/job/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/891/console
artifacts	http://artifacts.ci.centos.org/devtools/che-functional-tests/devtools-rh-che-rh-che-prcheck-dev.rdu2c.fabric8.io/891/

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

ibuziuk · 2018-12-10T12:34:00Z

@rhopp @ScrewTSW @Katka92 seems to be failing with:

OpenShift username and password and Keycloak token are not empty.
Tests are executed with user: rh-ch e-automation-preview
OSO_MASTER_URL found and set to: https://api.starter-us-east-2a.openshift.com
Active token has 1 sections.
JWT token parse failed!

Any ideas what is the reason ?

Katka92 · 2018-12-10T13:03:01Z

I think that the problem is in a way obtaining active token for test user. I'll have a look and try to fix it ASAP.

ScrewTSW · 2018-12-10T13:14:23Z

@ibuziuk Fix for the issue. I have deleted keycloak token from the vault as it's not being used anymore. Sorry for the issues caused
#1137

ibuziuk · 2018-12-11T10:08:34Z

[test]

centos-ci · 2018-12-11T10:46:12Z

@jarifibrahim The che server [build 901] has been successfully deployed.

http://rhche-prcheck-1086.devtools-dev.ext.devshift.net

benoitf added status/code-review kind/enhancement labels Nov 21, 2018

Change node image from eclipse/node to che-centos-nodejs

ba45c6f

Use postgres-centos image instead of postgres

c410c36

ibuziuk self-requested a review November 21, 2018 16:00

jarifibrahim mentioned this pull request Nov 28, 2018

Remove volume from dockerfile sclorg/postgresql-container#301

Closed

Mount correct volume

dc8659f

Add volume definition to the machine

e03aa10

jarifibrahim dismissed ghost ’s stale review via e03aa10 December 7, 2018 09:59

amisevsk previously approved these changes Dec 7, 2018

View reviewed changes

assembly/fabric8-stacks/src/main/resources/stacks.json Show resolved Hide resolved

Use lowercase postgresdata

e5230c7

jarifibrahim dismissed amisevsk’s stale review via e5230c7 December 7, 2018 15:26

amisevsk previously approved these changes Dec 7, 2018

View reviewed changes

Remove npm install from Run command

5f95a3e

jarifibrahim dismissed amisevsk’s stale review via 5f95a3e December 10, 2018 07:27

Change scope of stack from general to advanced

df306c0

jarifibrahim commented Dec 10, 2018

View reviewed changes

ibuziuk approved these changes Dec 11, 2018

View reviewed changes

ibuziuk merged commit 092f109 into redhat-developer:master Dec 11, 2018

benoitf removed the status/code-review label Dec 11, 2018

jarifibrahim deleted the node-crud-stack branch December 11, 2018 13:18

Add new nodejs-postgres stack #1086

Add new nodejs-postgres stack #1086

Conversation

jarifibrahim commented Nov 21, 2018

What does this PR do?

What issues does this PR fix or reference?

How have you tested this PR?

centos-ci commented Nov 21, 2018

@jarifibrahim The che server [build 814] has been successfully deployed.

jarifibrahim commented Nov 21, 2018

sbose78 commented Nov 21, 2018

jarifibrahim commented Nov 21, 2018

centos-ci commented Nov 21, 2018

@jarifibrahim The che server [build 815] has been successfully deployed.

centos-ci commented Nov 21, 2018

@jarifibrahim The che server [build 816] failed.

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

ibuziuk commented Nov 21, 2018

jarifibrahim commented Nov 21, 2018

centos-ci commented Nov 21, 2018

@jarifibrahim The che server [build 817] failed.

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

ibuziuk commented Nov 21, 2018

ibuziuk commented Nov 21, 2018

centos-ci commented Nov 21, 2018

@jarifibrahim The che server [build 818] has been successfully deployed.

jarifibrahim commented Nov 21, 2018

jarifibrahim commented Nov 21, 2018

ibuziuk commented Nov 21, 2018

jarifibrahim commented Nov 22, 2018

jarifibrahim commented Nov 27, 2018 • edited Loading

sbose78 commented Nov 27, 2018 • edited Loading

jarifibrahim commented Nov 27, 2018

jarifibrahim commented Nov 28, 2018

centos-ci commented Dec 1, 2018

@jarifibrahim The che server [build 851] has been successfully deployed.

jarifibrahim commented Dec 1, 2018

centos-ci commented Dec 7, 2018

@jarifibrahim The che server [build 878] has been successfully deployed.

amisevsk left a comment

Choose a reason for hiding this comment

centos-ci commented Dec 7, 2018

@jarifibrahim The che server [build 885] has been successfully deployed.

jarifibrahim commented Dec 7, 2018

centos-ci commented Dec 10, 2018

@jarifibrahim The che server [build 886] failed.

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

centos-ci commented Dec 10, 2018

@jarifibrahim The che server [build 887] failed.

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

jarifibrahim Dec 10, 2018

Choose a reason for hiding this comment

ibuziuk Dec 10, 2018

Choose a reason for hiding this comment

jarifibrahim commented Dec 10, 2018

centos-ci commented Dec 10, 2018

@jarifibrahim The che server [build 888] failed.

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

ibuziuk commented Dec 10, 2018

centos-ci commented Dec 10, 2018

@jarifibrahim The che server [build 890] failed.

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

ibuziuk commented Dec 10, 2018

centos-ci commented Dec 10, 2018

@jarifibrahim The che server [build 891] failed.

If the build or deployment fails, the artifacts will not be present. Don't panic, just grab a towel.

ibuziuk commented Dec 10, 2018

Katka92 commented Dec 10, 2018

ScrewTSW commented Dec 10, 2018

ibuziuk commented Dec 11, 2018

centos-ci commented Dec 11, 2018

@jarifibrahim The che server [build 901] has been successfully deployed.

jarifibrahim commented Nov 27, 2018 •

edited

Loading

sbose78 commented Nov 27, 2018 •

edited

Loading