Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use stream to send files back to browser #58

Merged

Conversation

dgolovin
Copy link
Collaborator

@dgolovin dgolovin commented Feb 27, 2024

Fix improves loading speed of success page and resource used in it.
Fix #49.

Signed-off-by: Denis Golovin [email protected]

@dgolovin dgolovin requested a review from a team as a code owner February 27, 2024 05:27
Copy link
Collaborator Author

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it needs tests. I am looking how to use nock to mock sso responses during tests.

@slemeur slemeur modified the milestones: 1.0.0, 0.0.2 Feb 28, 2024
@dgolovin dgolovin merged commit 7d270b8 into redhat-developer:main Feb 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty page is shown in browser after sucessful authentication
3 participants