Update AMD Operator and NFD install scripts #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robot Results
|
bdattoma
added
the
enhancements
bdattoma
force-pushed
the
amd_nfd_updates
branch
from
0ba9648 to
3395803
Compare
bdattoma
added
needs testing
jstourac
reviewed
Jan 8, 2025
jstourac
previously approved these changes
Jan 8, 2025
bdattoma
force-pushed
the
amd_nfd_updates
branch
from
6a9e5ee to
883754c
Compare
jstourac
previously approved these changes
Jan 8, 2025
apodhrad
approved these changes
Jan 9, 2025
jstourac
approved these changes
Jan 10, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: apodhrad, bdattoma, jstourac The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
bdattoma
merged commit a005254
into
red-hat-data-services:master
11 of 12 checks passed
bdattoma
added a commit
to bdattoma/ods-ci
that referenced
this pull request
Jan 10, 2025
* workaround for amd certified operator in ocp < 4.16 * add NFD installation script and use it in AMD script * use NFD install script in NVIDIA script * minor change * update warn msg * rm unused function
bdattoma
added a commit
to bdattoma/ods-ci
that referenced
this pull request
Jan 10, 2025
* workaround for amd certified operator in ocp < 4.16 * add NFD installation script and use it in AMD script * use NFD install script in NVIDIA script * minor change * update warn msg * rm unused function
bdattoma
added a commit
to bdattoma/ods-ci
that referenced
this pull request
Jan 10, 2025
* workaround for amd certified operator in ocp < 4.16 * add NFD installation script and use it in AMD script * use NFD install script in NVIDIA script * minor change * update warn msg * rm unused function
bdattoma
added a commit
to bdattoma/ods-ci
that referenced
this pull request
Jan 10, 2025
* workaround for amd certified operator in ocp < 4.16 * add NFD installation script and use it in AMD script * use NFD install script in NVIDIA script * minor change * update warn msg * rm unused function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is addressing 2 issues:
Proposed solutions:
A note about 2: we could fetch the image dynamically using the vx.y label, however this wouldn't be compatible with our disconnected cluster automation. Hence, for now, we are going with fixed image digests
MR validation:
rhoai-test-flow/2157PASSrhoai-test-flow/2158PASS