Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize sample pipelines in "cache-enabled" and "cache-disabled" folders #1891

Merged
merged 14 commits into from
Oct 9, 2024
Merged

Reorganize sample pipelines in "cache-enabled" and "cache-disabled" folders #1891

merged 14 commits into from
Oct 9, 2024

Conversation

jgarciao
Copy link
Contributor

@jgarciao jgarciao commented Oct 4, 2024 •
edited
Loading

  • Reorganizes sample pipelines in "cache-enabled" and "cache-disabled" folders
  • Python files reformatted with ruff format. Linter warnings fixed or disabled

Signed-off-by: Jorge Garcia Oncins [email protected]

@jgarciao jgarciao added enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins labels Oct 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
547 0 0 547 100

FedeAlonso
FedeAlonso previously approved these changes Oct 4, 2024
View reviewed changes
@jgarciao
Fix dsp upgrade testing sample
facc19d 
Signed-off-by: Jorge Garcia Oncins <[email protected]>
@jgarciao
Fix again path to upgrade pipeline sample
93dfc87 
Signed-off-by: Jorge Garcia Oncins <[email protected]>
@jgarciao
Fix linter formatting error
78b6c38 
Signed-off-by: Jorge Garcia Oncins <[email protected]>
@jgarciao
Copy link
Contributor Author

jgarciao commented Oct 7, 2024

Tested successfully in rhods-ci-pr-test/3382 (1 test failing for unrelated reasons)

@jgarciao jgarciao requested a review from FedeAlonso October 7, 2024 14:27
@jgarciao jgarciao changed the title Disable caching in all sample pipelines except the ones in the cache-enabled folder Reorganize sample pipelines in "cache-enabled" and "cache-disabled" folders Oct 7, 2024
FedeAlonso
FedeAlonso previously approved these changes Oct 7, 2024
View reviewed changes
diegolovison
diegolovison suggested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@diegolovison diegolovison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default setting in KFP is to have caching enabled. Changing the default in ODS-CI to have caching disabled makes it more difficult to remember the original default behavior. We should align with the upstream configuration.

ods_ci/libs/DataSciencePipelinesKfp.py Outdated Show resolved Hide resolved
ods_ci/tests/Tests/1100__data_science_pipelines/1105__data-science-pipelines-gpu-nvidia.robot Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jgarciao jgarciao requested a review from diegolovison October 8, 2024 16:57
@FedeAlonso FedeAlonso self-requested a review October 8, 2024 18:44
@jgarciao jgarciao merged commit f08ca85 into red-hat-data-services:master Oct 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeAlonso FedeAlonso FedeAlonso approved these changes

@diegolovison diegolovison diegolovison approved these changes

Assignees
No one assigned
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgarciao @diegolovison @FedeAlonso @lugi0