-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch kustomize for GPUs to provision in regions without zones on Azure #1888
Patch kustomize for GPUs to provision in regions without zones on Azure #1888
Conversation
Robot Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Don't have thorough knowledge here, but seems good.
Don't like those missing new-lines warnings, though 😁
for some reasons adding a new line in my local branch of the file, doesn't mark the files as changed wrt remote branch..I tried to fix the new line error but I prefer not spending more time on it now. let's see if the warning disappears after the last sync I did |
Quality Gate passedIssues Measures |
In order to support provisioning of GPUs in some regions of Azure where availability zone are not present we need to skip removal of "zone" key
Notes:
west us
is the only one without zonesPR validation (on local CI):