Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Registry e2e UI test + breaking ui changes #1879

Merged
merged 11 commits into from
Oct 2, 2024

Conversation

lugi0
Copy link
Contributor

@lugi0 lugi0 commented Oct 1, 2024

No description provided.

@lugi0 lugi0 requested a review from tonyxrmdavidson October 1, 2024 16:23
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
547 0 0 547 100

@lugi0 lugi0 self-assigned this Oct 2, 2024
Signed-off-by: lugi0 <[email protected]>
@lugi0 lugi0 marked this pull request as ready for review October 2, 2024 13:19
@lugi0
Copy link
Contributor Author

lugi0 commented Oct 2, 2024

Verified in rhoai-test-flow/657

@lugi0 lugi0 requested a review from nehachopra27 October 2, 2024 13:19
Copy link

sonarqubecloud bot commented Oct 2, 2024

@lugi0 lugi0 requested a review from jstourac October 2, 2024 13:20
@lugi0
Copy link
Contributor Author

lugi0 commented Oct 2, 2024

@jstourac adding you as a reviewer as well because of some changes to ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Workbenches.resource and ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterLabLauncher.robot

@lugi0 lugi0 added verified This PR has been tested with Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Oct 2, 2024
Copy link
Contributor

@tonyxrmdavidson tonyxrmdavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run this pr locally and the test passed.

Copy link
Contributor

@CFSNM CFSNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lugi0 lugi0 merged commit 5bb08b7 into red-hat-data-services:master Oct 2, 2024
8 checks passed
Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thank you for the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants