enhancement: include model registry namespace as part of the uninstalling #1873
Conversation
CFSNM
force-pushed
the
model_registry_namespace_uninstall
branch
from
b2cd83c to
677f750
Compare
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -110,7 +110,10 @@ | |||
| ${return_code} ${output} Run And Return Rc And Output | |||
| ... oc delete operatorgroup --all -n ${OPERATOR_NAMESPACE} --ignore-not-found | |||
| Should Be Equal As Integers ${return_code} 0 msg=Error deleting operatorgroup | |||
| Log To Console message=Deleting Operator and it's associate namepsace | |||
| Log To Console message=Deleting model registry associated namespace ${MODEL_REGISTRY_NAMESPACE} | |||
| ${return_code} ${output} Run And Return Rc And Output oc delete ns ${MODEL_REGISTRY_NAMESPACE} --ignore-not-found | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning
| @@ -110,7 +110,10 @@ | |||
| ${return_code} ${output} Run And Return Rc And Output | |||
| ... oc delete operatorgroup --all -n ${OPERATOR_NAMESPACE} --ignore-not-found | |||
| Should Be Equal As Integers ${return_code} 0 msg=Error deleting operatorgroup | |||
| Log To Console message=Deleting Operator and it's associate namepsace | |||
| Log To Console message=Deleting model registry associated namespace ${MODEL_REGISTRY_NAMESPACE} | |||
| ${return_code} ${output} Run And Return Rc And Output oc delete ns ${MODEL_REGISTRY_NAMESPACE} --ignore-not-found | |||
Check warning
Code scanning / Robocop
Local variable '{{ name }}' is overwritten before usage Warning
| @@ -110,7 +110,10 @@ | |||
| ${return_code} ${output} Run And Return Rc And Output | |||
| ... oc delete operatorgroup --all -n ${OPERATOR_NAMESPACE} --ignore-not-found | |||
| Should Be Equal As Integers ${return_code} 0 msg=Error deleting operatorgroup | |||
| Log To Console message=Deleting Operator and it's associate namepsace | |||
| Log To Console message=Deleting model registry associated namespace ${MODEL_REGISTRY_NAMESPACE} | |||
| ${return_code} ${output} Run And Return Rc And Output oc delete ns ${MODEL_REGISTRY_NAMESPACE} --ignore-not-found | |||
Check warning
Code scanning / Robocop
Local variable '{{ name }}' is overwritten before usage Warning
Robot Results
|
| @@ -110,7 +110,10 @@ Uninstall RHODS V2 | |||
| ${return_code} ${output} Run And Return Rc And Output | |||
| ... oc delete operatorgroup --all -n ${OPERATOR_NAMESPACE} --ignore-not-found | |||
| Should Be Equal As Integers ${return_code} 0 msg=Error deleting operatorgroup | |||
| Log To Console message=Deleting Operator and it's associate namepsace | |||
| Log To Console message=Deleting model registry associated namespace ${MODEL_REGISTRY_NAMESPACE} | |||
| ${return_code} ${output} Run And Return Rc And Output oc delete ns ${MODEL_REGISTRY_NAMESPACE} --ignore-not-found | |||
There was a problem hiding this comment.
Why is this needed here and the other namespaces don't have to be deleted separately here?
There was a problem hiding this comment.
the model registry namespace does not include the label opendatahub.io/generated-namespace so its not deleted by the command in line 117
There was a problem hiding this comment.
let me ask the platform devs
There was a problem hiding this comment.
@jstourac I am going to close this PR and revert the other one. This namespace is not intended to be deleted when uninstalling the operator, because there can be some model registry instances that need to be kept even if we delete the operator
there is a new namespace created downstream for the model registry named rhoai-model-registries. Deleting it as part of the uninstall process