Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pipelines E2E testing #1833

Merged
merged 1 commit into from
Oct 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
*** Settings ***
Documentation Data Science Pipelines Operator Integration Tests - https://github.com/opendatahub-io/data-science-pipelines-operator/tree/main/tests
Suite Setup Prepare Data Science Pipelines Operator Integration Tests Suite
Suite Teardown Teardown Data Science Pipelines Operator Integration Tests Suite
Suite Teardown RHOSi Teardown
Library OperatingSystem
Library Process
Resource ../../../tasks/Resources/RHODS_OLM/install/oc_install.robot
@@ -11,10 +11,9 @@

*** Variables ***
# For the initial commit we are hardcoding those environment variables
${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR} /tmp/data-science-pipelines-operator
${DSPO_SDK_DIR} /tmp/data-science-pipelines-operator
${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL} https://github.com/opendatahub-io/data-science-pipelines-operator.git
${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH} main
${DSPANAMESPACE} dspa-e2e
${KUBECONFIGPATH} %{HOME}/.kube/config

#robocop: disable: line-too-long
@@ -24,29 +23,24 @@
[Tags]
... DataSciencePipelines-Backend
... Tier1
... ODS-2632 AutomationBug
... ODS-2632
${openshift_api} Get Openshift Server
Log ${openshift_api}
${return_code} ${output} Run And Return Rc And Output cd ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR} && make integrationtest K8SAPISERVERHOST=${openshift_api} DSPANAMESPACE=${DSPANAMESPACE} KUBECONFIGPATH=${KUBECONFIGPATH}
${return_code} ${output} Run And Return Rc And Output cd ${DSPO_SDK_DIR} && GIT_WORKSPACE=${DSPO_SDK_DIR} sh .github/scripts/tests/tests.sh --rhoai --k8s-api-server-host ${openshift_api} --kube-config ${KUBECONFIGPATH} --dspa-path ${DSPO_SDK_DIR}/tests/resources/dspa.yaml --external-dspa-path ${DSPO_SDK_DIR}/tests/resources/dspa-external.yaml --clean-infra --endpoint-type route

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (393/120)
bdattoma marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests take a while to run. Could you try to use the Run And Watch Command keyword in Common.robot so we'll be able to see the results in the Console in realtime? (in this or a follow-up PR)

Log ${output}
Should Be Equal As Integers ${return_code} 0 msg= Run Data Science Pipelines Operator Integration Tests failed

#robocop: disable: line-too-long
*** Keywords ***
Prepare Data Science Pipelines Operator Integration Tests Suite
[Documentation] Prepare Data Science Pipelines Operator Integration Tests Suite
${return_code} ${output} Run And Return Rc And Output rm -fR ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR}
${return_code} ${output} Run And Return Rc And Output rm -fR ${DSPO_SDK_DIR}

Check warning

Code scanning / Robocop

Local variable '{{ name }}' is overwritten before usage Warning test

Local variable '${return_code}' is overwritten before usage
Log ${output}
${return_code} ${output} Run And Return Rc And Output git clone ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL} ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR}
${return_code} ${output} Run And Return Rc And Output git clone ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL} ${DSPO_SDK_DIR}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (141/120)
Log ${output}
Should Be Equal As Integers ${return_code} 0 msg=Unable to clone data-science-pipelines-operator repo ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL}:${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}:${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR}
${return_code} ${output} Run And Return Rc And Output cd ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_DIR} && git checkout -b it_test origin/${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}
Should Be Equal As Integers ${return_code} 0 msg=Unable to clone data-science-pipelines-operator repo ${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_URL}:${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}:${DSPO_SDK_DIR}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (227/120)
${return_code} ${output} Run And Return Rc And Output cd ${DSPO_SDK_DIR} && git checkout -b it_test origin/${DATA-SCIENCE-PIPELINES-OPERATOR-SDK_REPO_BRANCH}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (171/120)

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${output}' is assigned but not used
Should Be Equal As Integers ${return_code} 0 msg=Unable to checkout data-science-pipelines-operator
RHOSi Setup
${rc} ${out}= Run And Return Rc And Output oc new-project ${DSPANAMESPACE}
Should Be Equal As Integers ${rc} 0 msg=Cannot create a new project ${DSPANAMESPACE}

Teardown Data Science Pipelines Operator Integration Tests Suite
Copy link
Contributor

@bdattoma bdattoma Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We delegate to the DSPO test suite.

${return_code} ${output} Run And Return Rc And Output oc delete project ${DSPANAMESPACE} --force --grace-period=0
Log ${output}
RHOSi Teardown
# Store login information into dedicated config
Login To OCP Using API And Kubeconfig ${OCP_ADMIN_USER.USERNAME} ${OCP_ADMIN_USER.PASSWORD} ${KUBECONFIGPATH}
Loading