Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#172 Added isIdling state to the SelectionHandler #173

Conversation

oleksandr-danylchenko
Copy link
Contributor

@oleksandr-danylchenko oleksandr-danylchenko commented Nov 4, 2024

@oleksandr-danylchenko
Copy link
Contributor Author

@rsimon, here's an example of how the isIdling state can look like for the SelectionHandler. I intentionally chose to store just a single flag instead of some kind of enum, because that's the only state we're interested in for now. So it's more direct and takes less maintenance effort.

@oleksandr-danylchenko
Copy link
Contributor Author

oleksandr-danylchenko commented Nov 4, 2024

Another question is how to distribute that value to the selection state consumer. The Selection state is handled on the A9S side and shared via the Annotorious provider. So I think that one of the options would be to add the isIdling state there, but populate it only from within the R6O SelectionHandler for now.

@oleksandr-danylchenko oleksandr-danylchenko deleted the #172-fix-popup-flickering-selection branch November 5, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant