Simplified getAnnotationBounds

recogito · Nov 21, 2024 · 8ad4fae · 8ad4fae
1 parent 97ddea3
commit 8ad4fae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/packages/text-annotator/src/state/TextAnnotationStore.ts b/packages/text-annotator/src/state/TextAnnotationStore.ts
@@ -13,7 +13,7 @@ export interface TextAnnotationStore<T extends TextAnnotation = TextAnnotation>
 
   getAnnotationRects(id: string): DOMRect[];
 
-  getAnnotationBounds(id: string, hintX?: number, hintY?: number, buffer?: number): DOMRect | undefined;
+  getAnnotationBounds(id: string): DOMRect | undefined;
 
   getAnnotationRects(id: string): DOMRect[];
 

diff --git a/packages/text-annotator/src/state/TextAnnotatorState.ts b/packages/text-annotator/src/state/TextAnnotatorState.ts
@@ -114,19 +114,9 @@ export const createTextAnnotatorState = <I extends TextAnnotation = TextAnnotati
     return all ? filtered : filtered[0];
   }
 
-  const getAnnotationBounds = (id: string, x?: number, y?: number, buffer = 5): DOMRect | undefined => {
+  const getAnnotationBounds = (id: string): DOMRect | undefined => {
     const rects = tree.getAnnotationRects(id);
-    if (rects.length === 0) return;
-
-    if (x && y) {
-      const match = rects.find(({ top, right, bottom, left }) =>
-        x >= left - buffer && x <= right + buffer && y >= top - buffer && y <= bottom + buffer);
-
-      // Preferred bounds: the rectangle
-      if (match) return match;
-    }
-
-    return tree.getAnnotationBounds(id);
+    return rects.length > 0 ? tree.getAnnotationBounds(id) : undefined;
   }
 
   const getIntersecting = (