Fix to make Copy/Paste keyboard shortcuts working with useSelection #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reagraph ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amcdnl
requested changes
Jan 6, 2025
src/selection/useSelection.ts
Outdated
| const isSafe = | ||
| element.tagName !== 'INPUT' && | ||
| element.tagName !== 'SELECT' && | ||
| element.tagName !== 'TEXTAREA' && | ||
| !element.isContentEditable; | ||
|
|
||
| const isMeta = event.metaKey || event.ctrlKey; | ||
| const isSystemShortcut = ['c', 'x', 'v'].includes(event.key.toLowerCase()); |
There was a problem hiding this comment.
I'm not sure this is the right approach considering this could change based on user hotkey or locale. I think removing the preventDefault is probably the right move, I don't remember why we added that in the first place, can u test it doesn't break anything if removed and update to just remove that instead?
There was a problem hiding this comment.
It seems better indeed. I just tested and it works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
The aim of this PR is to fix issue #272 => Copy/Paste/Refresh keyboard shortcuts not working if using useSelection Hook
What is the current behavior?
Issue Number: #272
What is the new behavior?
Copy paste is now working (you can try it for instance on the text 'Hold Cammand/CTRL ....') in the Modifier Key section.
Does this PR introduce a breaking change?
Other information