Refactor upload accept #1156
Open
Refactor upload accept #1156
+44
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochenklar
force-pushed
the
refactor_upload_accept
branch
from
0cc9bb3 to
d456f9f
Compare
CalamityC
approved these changes
Nov 21, 2024
| .then(importUrls => { | ||
| dispatch(fettchImportUrlsSuccess({ importUrls }))}) | ||
| const action = (dispatch) => ProjectsApi.fetchDirectImportUrls().then(importUrls => { | ||
| dispatch(fettchImportUrlsSuccess(importUrls)) |
There was a problem hiding this comment.
Can you please fix my typo? fettch -> fetch
| @@ -109,7 +109,7 @@ export function fetchImportUrlsInit() { | |||
| } | |||
|
|
|||
| export function fettchImportUrlsSuccess(importUrls) { | |||
There was a problem hiding this comment.
Same typo as above. Please fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the accept field for import plugins to match the format of react-dropzone, e.g.:
It also contains minor renaming in
projectActions.