Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add ratify on alibabacloud and add rrsa auth provider into oras… #130

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

docs: add ratify on alibabacloud and add rrsa auth provider into oras… #130

wants to merge 3 commits into from
+720 −0

Conversation

DahuK
Copy link

@DahuK DahuK commented Dec 10, 2024

  • add quick start doc for ratify on alibaba cloud
  • add RRSA auth provider description to oras doc

@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for ratify-dev ready!

Name Link
🔨 Latest commit 5bd8b5e
🔍 Latest deploy log https://app.netlify.com/sites/ratify-dev/deploys/6786fff0cc5785000860d76a
😎 Deploy Preview https://deploy-preview-130--ratify-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FeynmanZhou FeynmanZhou self-requested a review December 10, 2024 23:44
susanshi
susanshi previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thankyou so much for the PR. Left some minor comments, looks good to me.

versioned_docs/version-1.3/quickstarts/ratify-on-alibabacloud.md Outdated Show resolved Hide resolved
versioned_docs/version-1.3/quickstarts/ratify-on-alibabacloud.md Outdated Show resolved Hide resolved
versioned_docs/version-1.3/quickstarts/ratify-on-alibabacloud.md Outdated Show resolved Hide resolved
versioned_docs/version-1.3/quickstarts/ratify-on-alibabacloud.md Outdated Show resolved Hide resolved
versioned_docs/version-1.3/quickstarts/ratify-on-alibabacloud.md Outdated Show resolved Hide resolved
versioned_docs/version-1.3/quickstarts/ratify-on-alibabacloud.md Show resolved Hide resolved
yizha1
yizha1 reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DahuK for contribution. I left some comments

versioned_docs/version-1.3/quickstarts/ratify-on-alibabacloud.md Outdated Show resolved Hide resolved
versioned_docs/version-1.3/quickstarts/ratify-on-alibabacloud.md Outdated Show resolved Hide resolved
versioned_docs/version-1.3/quickstarts/ratify-on-alibabacloud.md Outdated Show resolved Hide resolved
versioned_docs/version-1.3/quickstarts/ratify-on-alibabacloud.md Outdated Show resolved Hide resolved
versioned_docs/version-1.3/quickstarts/ratify-on-alibabacloud.md Outdated Show resolved Hide resolved
docs/quickstarts/ratify-on-alibabacloud.md Outdated Show resolved Hide resolved
docs/quickstarts/ratify-on-alibabacloud.md Outdated Show resolved Hide resolved
docs/quickstarts/ratify-on-alibabacloud.md Outdated Show resolved Hide resolved
docs/quickstarts/ratify-on-alibabacloud.md Outdated Show resolved Hide resolved
docs/quickstarts/ratify-on-alibabacloud.md Outdated Show resolved Hide resolved
FeynmanZhou
FeynmanZhou reviewed Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest scanning the markdown syntax and wording issues. Check the preview page for details: https://deploy-preview-130--ratify-dev.netlify.app/docs/quickstarts/ratify-on-alibabacloud

@DahuK DahuK force-pushed the ratify-on-alibabalcoud branch 3 times, most recently from 3a4685d to d67a3ab Compare December 20, 2024 03:37
@DahuK
Copy link
Author

DahuK commented Dec 20, 2024

@FeynmanZhou @yizha1 @susanshi Thanks for your review! I have revised the doc, please take another look when you free.

@DahuK DahuK force-pushed the ratify-on-alibabalcoud branch 2 times, most recently from d868e16 to 4b43668 Compare January 7, 2025 13:30
@yizha1
Copy link
Contributor

yizha1 commented Jan 7, 2025

@DahuK Thanks for the updates and happy new year. I just mentioned you for two comments not resolved yet.

@DahuK DahuK force-pushed the ratify-on-alibabalcoud branch from 4b43668 to c5178c8 Compare January 8, 2025 02:49
@DahuK
Copy link
Author

DahuK commented Jan 8, 2025

@DahuK Thanks for the updates and happy new year. I just mentioned you for two comments not resolved yet.

Happy New Year, @yizha1 ! Thanks for your reminder. All comments should be resolved now.

@yizha1
Copy link
Contributor

yizha1 commented Jan 8, 2025

@DahuK Thanks for resolving comments. However, I did not see the following comments resolved, could you please check it again? Thanks.

#130 (comment)
#130 (comment)

@DahuK DahuK force-pushed the ratify-on-alibabalcoud branch from c5178c8 to c789bcf Compare January 9, 2025 07:33
@DahuK
Copy link
Author

DahuK commented Jan 9, 2025

@DahuK Thanks for resolving comments. However, I did not see the following comments resolved, could you please check it again? Thanks.

#130 (comment) #130 (comment)

Sorry, I missed these two comments. Thanks @yizha1, I have updated the PR, please check again when you free.

@yizha1
Copy link
Contributor

yizha1 commented Jan 10, 2025

@DahuK There is still one place the ORAS tool is mis-spelled, you can search "ORSA" in docs/quickstarts/ratify-on-alibabacloud.md, it should be "ORAS".

@DahuK DahuK force-pushed the ratify-on-alibabalcoud branch from c789bcf to 9495bcc Compare January 13, 2025 02:24
@DahuK
Copy link
Author

DahuK commented Jan 13, 2025

@DahuK There is still one place the ORAS tool is mis-spelled, you can search "ORSA" in docs/quickstarts/ratify-on-alibabacloud.md, it should be "ORAS".

Fixed, thanks @yizha1 !

@DahuK DahuK force-pushed the ratify-on-alibabalcoud branch from 9495bcc to 5dbd40b Compare January 13, 2025 13:23
@DahuK
Copy link
Author

DahuK commented Jan 13, 2025

@binbin-li Thanks! Fixed the typo.

yizha1
yizha1 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DahuK LGTM. Thanks for your great efforts. We can do small improvements on the document if needed later.

@FeynmanZhou
Copy link
Collaborator

The CI deployment check looks failed. Let me look into the CI issue. We will hold on the PR until the CI job runs successfully.

@FeynmanZhou
Copy link
Collaborator

FeynmanZhou commented Jan 13, 2025 •
edited
Loading

After my investigation, my guess is this PR may included many picture files which makes the build time out and beyond the free quota of the web hosting platform (See related issue).

@DahuK For testing purposes, would you mind removing those 4 screenshot pictures and try to build the website in your local? You can follow the README to run and build the website locally: https://github.com/ratify-project/ratify-web?tab=readme-ov-file#build

FeynmanZhou
FeynmanZhou approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou
Copy link
Collaborator

Now the preview link looks good: https://deploy-preview-130--ratify-dev.netlify.app/docs/quickstarts/ratify-on-alibabacloud

@FeynmanZhou FeynmanZhou requested a review from susanshi January 15, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binbin-li binbin-li binbin-li left review comments

@yizha1 yizha1 yizha1 approved these changes

@FeynmanZhou FeynmanZhou FeynmanZhou approved these changes

@akashsinghal akashsinghal Awaiting requested review from akashsinghal akashsinghal is a code owner

@luisdlp luisdlp Awaiting requested review from luisdlp luisdlp is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@susanshi susanshi Awaiting requested review from susanshi susanshi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DahuK @yizha1 @FeynmanZhou @binbin-li @susanshi