Replace pip installation with APT for python-openshift #114

anthr76 · 2021-03-02T12:37:52Z

Description

Let python-openshift be managed with APT instead of PIP. I'm maintaining a repo for various debian flavors but at the moment 20.04 is hardcoded. We'll remain to pull in from the AUR for arch linux.

Checklist

All commits are signed off. See the section Developer’s Certificate of Origin
Provide a title or release-note blurb suitable for the release notes.
All commits contain a well written commit description including a title, description and a Fixes: #XXX line if the commit addresses a particular GitHub issue.
All workflow validation and compliance checks are passing.

Notes

Resolves tech debt from #72

Signed-off-by: anthr76 <[email protected]>

rkage · 2021-03-02T13:49:19Z

ansible/roles/common/tasks/debian.yml

+
+- name: 'install openshift kubernetes module (3/3)'
+  apt:
+    name: python-openshift


Do we use this anywhere?

We do in Cilium.

k8s-cluster-installation/ansible/roles/cni/tasks/cilium.yml

Lines 24 to 54 in 0586a6f

community.kubernetes.helm_repository:

name: cilium

repo_url: "https://helm.cilium.io/"

- name: deploy Cilium

community.kubernetes.helm:

name: cilium

chart_ref: cilium/cilium

release_namespace: kube-system

chart_version: "{{ cni_cilium_helm_version }}"

values: "{{ lookup('template', 'values.yaml.j2') | from_yaml }}"

- name: patch cilium-operator for helm chart bug

community.kubernetes.k8s:

state: present

definition:

apiVersion: apps/v1

kind: Deployment

metadata:

name: cilium-operator

namespace: kube-system

spec:

template:

spec:

containers:

- name: cilium-operator

image: cilium/operator-dev:{{ cni_cilium_image_version }}

- name: Apply kube-router manifests

community.kubernetes.k8s:

Likely elsewhere if the community is in agreeance, and sees fit for other CNI deployments etc

commit: 0c527dc

I wonder if this is purely in usage for the CNI should we keep it here or move it to the respective role?

Good question. If we slot in CNI role we'll have to do distro based checks. The equivalent to this for Arch is also in common. In my opinion it would make sense here.

Just to add on to this tidbit. If we were to move forward with issues like this it would make more sense to keep this in common.

anthr76 · 2021-03-02T15:46:11Z

Tested against Ubuntu 20.04 x86 https://gist.github.com/anthr76/7ad52523cb6778fc78057d835b1ce97d#file-gistfile0-txt-L127-L144

xunholy

I'm happy with this change, will wait to let @rkage to leave any further feedback.

* Remove pip as a common package and replace it with `python-openshift` from OBS * Add OBS key before installing common packages to ensure `python-openshift` gets pulled in. * Since an AUR package exists for `python-openshift` remove pip from Arch and install from AUR. Signed-off-by: anthr76 <[email protected]>

anthr76 · 2021-03-03T12:30:56Z

Upstream issue tracking:

openshift/openshift-restclient-python#392
https://github.com/openshift/openshift-restclient-python/pull/57/files
openshift/openshift-restclient-python#241
openshift/openshift-restclient-python#271

Replace pip installation with APT.

ec23c63

Signed-off-by: anthr76 <[email protected]>

pull-request-size bot added the size/S label Mar 2, 2021

rkage reviewed Mar 2, 2021

View reviewed changes

xunholy approved these changes Mar 3, 2021

View reviewed changes

rkage approved these changes Mar 6, 2021

View reviewed changes

anthr76 merged commit 0e87edb into main Mar 6, 2021

anthr76 deleted the openshift-module branch March 6, 2021 13:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace pip installation with APT for python-openshift #114

Replace pip installation with APT for python-openshift #114

anthr76 commented Mar 2, 2021 •

edited

Loading

rkage Mar 2, 2021

anthr76 Mar 2, 2021

anthr76 Mar 2, 2021

xunholy Mar 2, 2021

anthr76 Mar 2, 2021

anthr76 Mar 3, 2021

anthr76 commented Mar 2, 2021

xunholy left a comment

anthr76 commented Mar 3, 2021

	community.kubernetes.helm_repository:
	name: cilium
	repo_url: "https://helm.cilium.io/"

	- name: deploy Cilium
	community.kubernetes.helm:
	name: cilium
	chart_ref: cilium/cilium
	release_namespace: kube-system
	chart_version: "{{ cni_cilium_helm_version }}"
	values: "{{ lookup('template', 'values.yaml.j2') \| from_yaml }}"

	- name: patch cilium-operator for helm chart bug
	community.kubernetes.k8s:
	state: present
	definition:
	apiVersion: apps/v1
	kind: Deployment
	metadata:
	name: cilium-operator
	namespace: kube-system
	spec:
	template:
	spec:
	containers:
	- name: cilium-operator
	image: cilium/operator-dev:{{ cni_cilium_image_version }}


	- name: Apply kube-router manifests
	community.kubernetes.k8s:

Replace pip installation with APT for python-openshift #114

Replace pip installation with APT for python-openshift #114

Conversation

anthr76 commented Mar 2, 2021 • edited Loading

Description

Checklist

Notes

rkage Mar 2, 2021

Choose a reason for hiding this comment

anthr76 Mar 2, 2021

Choose a reason for hiding this comment

anthr76 Mar 2, 2021

Choose a reason for hiding this comment

xunholy Mar 2, 2021

Choose a reason for hiding this comment

anthr76 Mar 2, 2021

Choose a reason for hiding this comment

anthr76 Mar 3, 2021

Choose a reason for hiding this comment

anthr76 commented Mar 2, 2021

xunholy left a comment

Choose a reason for hiding this comment

anthr76 commented Mar 3, 2021

anthr76 commented Mar 2, 2021 •

edited

Loading