Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest ci-conda images #17690

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Use latest ci-conda images #17690

merged 1 commit into from
Jan 8, 2025

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 7, 2025

Description

Use ci-conda:latest tags for all jobs. All jobs should now support ci-conda:latest, and older pinnings are probably not necessary anymore.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 7, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@bdice
Copy link
Contributor Author

bdice commented Jan 7, 2025

/ok to test

@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 7, 2025
@bdice bdice marked this pull request as ready for review January 8, 2025 15:01
@bdice bdice requested a review from a team as a code owner January 8, 2025 15:01
@bdice bdice requested a review from raydouglass January 8, 2025 15:01
jameslamb
jameslamb approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this, based on the similar discussion we had in rapidsai/cugraph-gnn#96 (comment)

@jameslamb jameslamb removed the request for review from raydouglass January 8, 2025 15:40
@bdice
Copy link
Contributor Author

bdice commented Jan 8, 2025

/merge

@rapids-bot rapids-bot bot merged commit 76f1c8b into rapidsai:branch-25.02 Jan 8, 2025
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

Assignees

@bdice bdice

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @jameslamb