Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert all nulls to nans in a specific scenario #17677

Open
wants to merge 8 commits into
base: branch-25.02
Choose a base branch
from
Open

convert all nulls to nans in a specific scenario #17677

wants to merge 8 commits into from
+14 −1

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Jan 3, 2025 •
edited
Loading

Description

Fixes: #17666

This PR ensures we convert all nulls to nan's in float columns only in pandas compatibility mode.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 2 - In Progress Currently a work in progress non-breaking Non-breaking change labels Jan 3, 2025
@galipremsagar galipremsagar self-assigned this Jan 3, 2025
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 3, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@galipremsagar
Copy link
Contributor Author

/okay to test

@github-actions github-actions bot added the Python Affects Python cuDF API. label Jan 3, 2025
@galipremsagar
Copy link
Contributor Author

/okay to test

@galipremsagar
Copy link
Contributor Author

/okay to test

@galipremsagar
Copy link
Contributor Author

/okay to test

@galipremsagar galipremsagar marked this pull request as ready for review January 9, 2025 17:10
@galipremsagar galipremsagar requested a review from a team as a code owner January 9, 2025 17:10
@galipremsagar galipremsagar requested review from vyasr and Matt711 January 9, 2025 17:10
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jan 9, 2025
mroeschke
mroeschke approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggested renaming of a test

python/cudf/cudf/tests/test_series.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@Matt711 Matt711 Awaiting requested review from Matt711 Matt711 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] using python -m cudf.pandas and calling hasattr converts NA to NaN
2 participants
@galipremsagar @mroeschke